From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f49.google.com (mail-yx1-f49.google.com [74.125.224.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 255282D12EA for ; Mon, 24 Nov 2025 17:46:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764006415; cv=none; b=RnxnLG1bnSbqNP5L5ePGQjKwZePQnlsuyODWcX9LRNlqrjAMK0DzZLO86wKtHmOk1wy/eGE7o6Q47mIcLvdsX6ONmEYXzrKPxxEth0drWWReYZnGNdhXo/cNtfQ0ZexK3HvU7PlmspDxbjVCXs1U1sfjOJk+AsY9CW7wwHVRM8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764006415; c=relaxed/simple; bh=5QMUaB3UItvdOk2MFBD3uzK1qE9srvOCD3sKMnkMU7w=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=L65HwdCbipPRLn+SXJH5pbLQaA0WDpliFghzjh8ZHVODvk29fG/tdYNmY0BylRKOhmXpUUsNt986jGP0dlZZ2vYZmV0U/mip1onuqdDRtxxuZoTgLM/3n5xBguo31yV3yqm7qwrSbtcay7w/aJWtiO0tiCapmhMGcYK30tAAD28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GQcv2Wfs; arc=none smtp.client-ip=74.125.224.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GQcv2Wfs" Received: by mail-yx1-f49.google.com with SMTP id 956f58d0204a3-63fc72db706so3808827d50.2 for ; Mon, 24 Nov 2025 09:46:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764006413; x=1764611213; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=0hvHQdU4GV30EKSntbN+1hV2iN97Sxz4IGxkWVntgLM=; b=GQcv2WfsBNv2Kpc2YsojWOmO1oHedfglyzir1ERidEop6Z8cMHcgRT8gl2Ku8tKn7o hBi9m1oCD9tGyam0Z+J63xafOOLN7Kgqjjl9oeY2n52wgMrIbvkPfXdmTNLLkjhLNUHF OdTQvrsbzOqu0ImtwJCGXIO5wxfEuz1ZGiComjQYUw8y2m6Xh+c5ELsKrkhtUvZNozjP J923F+I91pmK0OE34zUyTnsZAMebTPSWzM3r962tnx6O303xGy35dqhptnQjFB945off MNmYudhuFBLibwEo/FeyEl/fXI/q6dt/XCHczikDbNargi5ECQlRCtaVtTS1bngswy/a 8Fpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764006413; x=1764611213; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0hvHQdU4GV30EKSntbN+1hV2iN97Sxz4IGxkWVntgLM=; b=Ao+KueOtm9vVnBP7SjuJzscBiiDy1YEpqRssP2AfuPfiVsLjXlTGlGvEjm6RpbbFkM NIJG0l5XYfideijlq/9dEpWTqEa7Ee1GYBO+3uDfcI+z5KZafrlYePXmTalsZXdTru5n 8EGwVCQVEHVAPdsnPsgI0JJzTrmyBzTeMZDRLh47Hg0+nYSJzO9/R/qrz2cgxgc0fGeq vZrgA2J/nsOnoOgXYMrObKdrC/nZNWBtnFbRHnAp5M1i+78aNMO7oIqyfDE5WdpiDGUp n5MsvbNvs9nmBUmUOZoxSZQvuZYZ/KeVSP6GZ4X8Rsa/9mdMFicqcizogNBCSn+ltFqk oYMg== X-Forwarded-Encrypted: i=1; AJvYcCXl8xesY0whiKd/KvTfUuLiI5bXNRHIDi7nJrB0B8z1MgI+9AXUX0DCBhshG/wRsWL2EBm+hlOfS0PhbDU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5mESyQq8RNmfaSwFW3UwLXzayB9F/seWfD0P2g9Vcm5nJX16J 42JExS73Gov3QRy/cX9PNfT62bdFCOKidnVMMJo6mLv6USxpd1hRPfMS X-Gm-Gg: ASbGncuT382aqMgGwb3MDWjE6H1iU8U0WptibpgjK0Cd4CuhdPFDrC08ld0/XUaf9kY PVIk1yoAqy7jducvutOwqYvUOtjuuhDu1EEzP7xpCaf+6xQX3SjjTPuhCk9dleXrLDUaBkXr3Ej MYNjzYEJQjEU3/yCMiNcyQ13ZyZB5Br/1kTXjSTaEp136EozPtQiCwBEVlIJfx4/wZd/jdzdDDu KSuFz0jWdSoF/a1/SQzBIAMzsPtKjX3gFjbks7e3p554wYFv93or+FQYGo4Of/EnIm89s8xV2mC rGj70Z6nblVF093guM50Ugy1W7K6dGqty8EMKhn//SGWld+KmHxk68daPBqNWnl67ceJ/Ag7Cu6 Mi7+mbKONXMDJKqxyHK1v/Usu/SiOvb2NHQAGw0Q5bVX1aeV4TadIvZipM3xro8F2MXjvu6Rl5l QpetBsRq0M8vs++NdPjICOwuJKFuBj45ks2iZ2RIzPAt0eylVR8jggO24U/Q2kthJdf7E= X-Google-Smtp-Source: AGHT+IFZLS+sg4uY4W+GnSk7FxLFLQkNJQifO8MidMav+DX9v0PbFy6py458azKZF49Wq/pFCb5C9w== X-Received: by 2002:a05:690e:4298:10b0:63f:9cef:d5f4 with SMTP id 956f58d0204a3-64302abbe69mr7439363d50.36.1764006412975; Mon, 24 Nov 2025 09:46:52 -0800 (PST) Received: from gmail.com (116.235.236.35.bc.googleusercontent.com. [35.236.235.116]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-78a798a5decsm46733137b3.21.2025.11.24.09.46.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 09:46:52 -0800 (PST) Date: Mon, 24 Nov 2025 12:46:52 -0500 From: Willem de Bruijn To: Ankit Khushwaha , Willem de Bruijn , Jason Xing , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Ankit Khushwaha Message-ID: In-Reply-To: <20251124161324.16901-1-ankitkhushwaha.linux@gmail.com> References: <20251124161324.16901-1-ankitkhushwaha.linux@gmail.com> Subject: Re: [PATCH] selftests/net: initialize char variable to null Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Ankit Khushwaha wrote: > char variable in 'so_txtime.c' & 'txtimestamp.c' left uninitilized > by when switch default case taken. raises following warning. > > txtimestamp.c:240:2: warning: variable 'tsname' is used uninitialized > whenever switch default is taken [-Wsometimes-uninitialized] > > so_txtime.c:210:3: warning: variable 'reason' is used uninitialized > whenever switch default is taken [-Wsometimes-uninitialized] > > initialize these variables to NULL to fix this. > > Signed-off-by: Ankit Khushwaha These are false positives as the default branches in both cases exit the program with error(..). Since we do not observe these in normal kernel compilations: are you enabling non-standard warnings? > --- > tools/testing/selftests/net/so_txtime.c | 2 +- > tools/testing/selftests/net/txtimestamp.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/net/so_txtime.c b/tools/testing/selftests/net/so_txtime.c > index 8457b7ccbc09..b76df1efc2ef 100644 > --- a/tools/testing/selftests/net/so_txtime.c > +++ b/tools/testing/selftests/net/so_txtime.c > @@ -174,7 +174,7 @@ static int do_recv_errqueue_timeout(int fdt) > msg.msg_controllen = sizeof(control); > > while (1) { > - const char *reason; > + const char *reason = NULL; > > ret = recvmsg(fdt, &msg, MSG_ERRQUEUE); > if (ret == -1 && errno == EAGAIN) > diff --git a/tools/testing/selftests/net/txtimestamp.c b/tools/testing/selftests/net/txtimestamp.c > index dae91eb97d69..bcc14688661d 100644 > --- a/tools/testing/selftests/net/txtimestamp.c > +++ b/tools/testing/selftests/net/txtimestamp.c > @@ -217,7 +217,7 @@ static void print_timestamp_usr(void) > static void print_timestamp(struct scm_timestamping *tss, int tstype, > int tskey, int payload_len) > { > - const char *tsname; > + const char *tsname = NULL; > > validate_key(tskey, tstype); > > -- > 2.52.0 >