From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f50.google.com (mail-yx1-f50.google.com [74.125.224.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12CDA329C7F for ; Tue, 7 Apr 2026 21:52:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775598759; cv=none; b=JN7PSimspzv0FZIwPsnF9KIN7tDY9MbyEf+pXk3yD+LdD1U3NU7Ea7YI9ygFoBDjiHh2FE8JP70gWSy7nUsNeexa6ighFnTD5rBpcLbF84AdXY5lrtEjOvgQom8bKvpAMyAOfn3pTGeRdyuEQkRUOMgujbnZCBYcXrl68AAe9P8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775598759; c=relaxed/simple; bh=GUOIRPgsNNSFlmi7aDvlteP/x8XygeSuEUg4nnErU+0=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=gbFXJ7cnGWtuGcI79ZIgiEoJ2nbq1e+60Ibkf2hdqKKoGtMhwT71DNMB3fpt4JEQJwVa/LPhWuaRHoVeKUcb0v54wxmvZx7xUswMf3LiKvnKS741QIZgJpybyzkulAzjG1JMquYdBqH4AsfetY4UFclabF7Uzd/gnEuYMbTCDgY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RL17tiM3; arc=none smtp.client-ip=74.125.224.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RL17tiM3" Received: by mail-yx1-f50.google.com with SMTP id 956f58d0204a3-650775f427eso2030388d50.2 for ; Tue, 07 Apr 2026 14:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775598757; x=1776203557; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=2w95I/v5RzbUQ4D0ck4oEV5z84JMKw1rweKYpEZ2pxQ=; b=RL17tiM3idhwhys5KwE2WAX9aiOouHQB8yUbDs198uYp/0PgvHSj4Ny8ixuWGTR/qk 6Vcv/d4fehwFixzVYtmkfd4KB/kZ4anjr1cJKvuwbZmyIFzSiy+Hf7qfiiANogh98Vi3 JhUv+McrKnVspe693Rrij015rOPOw103801H9qzL6+DMjbX1HrKWSRP3uuBT4lm91zBJ If+IwKqb29LrWrf9qD3ezMLCV3WM5A+IjMWKGzdsY8Gq5sZB4vdyhsHOvqb3sjCNq9J1 2rqBJt+RDpySCuPnxwiXO1QhEqW5TePxjXTg0SfuTW4S5cGJFfRwa1Rs5hrsMW/p4iuD Ayzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775598757; x=1776203557; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2w95I/v5RzbUQ4D0ck4oEV5z84JMKw1rweKYpEZ2pxQ=; b=A2BEzBMMtOHOksHuR4sKUKH4GvlieLFKV+KacrRQkGZI02tTqHAzqtaIJJYX6YLBZu BfMxAzG//3BPGSd2FqnAEa3zCz4JiGaeqGOA/jP05NWkAZiy4uUfSRhjRFjKBcfzyGpf EDDuEvOuU9KX0nkg/FeuY/13YlWWXXcS3v3hxYdndlAiAXcMdAsw9UAngU5MqVo85K9t pbfyZaTxBh5Kd7wjR+ms9J033fnw13VW49T4YlL/G8VPTNTLav9I6sCae2l/2Pu7x8V/ gTeU8+wEUSwJgJajRJ7lsnYpqOQDcd/CnLjXzu3vGmP+HEFUiWbzszfND83HZq9CDKCA 5c6A== X-Forwarded-Encrypted: i=1; AJvYcCWnfVHPZ2+NzrKhdGj8mLc3B0M29g7jIO5wYBtvSJvqWLov3sNe9dQh4Ns1GNlBaX3yGhBnNvgDD4Sdcfk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxsh9BtlTvifWoXbwaQw2bhc0ma7oRVi0HgX7zp3J5rybHa5Qg4 UMLWBCoTso29J4J0ID47LLTm3Xw0oPQG/sZBNnPKiq6mzUDC0Xw2ZGW1 X-Gm-Gg: AeBDietV6D+lLouKOu136GLxa/6k2/uAWZA4wIexn4WpuS+QX5FBlGf/YixS+UFn03N MS1h8f8kK2wNxWTBrX7D9eCEIQZ+cYRNiFffo3Qpola8yZTUY3YNeLiEmIMEa8RJRk8oa0Qw97h ZxdD4g6NIMw4aailse7g7RsoJYfMySRmq1a8YI3ReqgBo8oNZcn6JMJOUMtyXTm9YF4xREYuXen H/kye8UUdpLCYWQpNOg/++YgRG3wS1tesbvPm4ODoaH01R28LOKCxatP3XRJCEdY1/kmXmC74y5 W4HVLvcnc6civgJFj2tKEMl4+dDLVi0hL+jgljRpsyNMwC7xQqVnlO64iPxDTVrOFaMEOUguYut CseXJTz51AMtETlAsV4hj5mZEa+wPmOvu7N0Ps220Lshy0JId1iaPA3plCWZRyWNBreMo36tsys 2suQ+LMqNUCOtYNIiGaFjkjCK1UyIIsq6yKnrIaAJOVl05oy5SWvhPBMx2cCwkfaUxGr8AeW25s KJE X-Received: by 2002:a05:690c:61ca:b0:79b:d362:4f63 with SMTP id 00721157ae682-7a4d86c1948mr191013067b3.29.1775598757107; Tue, 07 Apr 2026 14:52:37 -0700 (PDT) Received: from gmail.com (172.165.85.34.bc.googleusercontent.com. [34.85.165.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a4fc065bf6sm61978717b3.38.2026.04.07.14.52.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 14:52:36 -0700 (PDT) Date: Tue, 07 Apr 2026 17:52:36 -0400 From: Willem de Bruijn To: Akhilesh Samineni , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, willemb@google.com, daniel.zahka@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jayakrishnan.udayavarma@broadcom.com, ajit.khaparde@broadcom.com, kiran.kella@broadcom.com, akhilesh.samineni@broadcom.com, sachin.suman@broadcom.com Message-ID: In-Reply-To: <20260406222305.4111170-4-akhilesh.samineni@broadcom.com> References: <20260406222305.4111170-1-akhilesh.samineni@broadcom.com> <20260406222305.4111170-4-akhilesh.samineni@broadcom.com> Subject: Re: [PATCH net-next 3/3] selftests: net: psp: add crypt-offset and spi-threshold test cases Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Akhilesh Samineni wrote: > Add test cases to set and get crypt-offset and spi-threshold attributes, > verifying both the applied value and the restored prior value. > > Signed-off-by: Akhilesh Samineni > Reviewed-by: Kiran Kella > Reviewed-by: Ajit Kumar Khaparde > --- > tools/testing/selftests/drivers/net/psp.py | 32 ++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/tools/testing/selftests/drivers/net/psp.py b/tools/testing/selftests/drivers/net/psp.py > index 864d9fce1094..9253aab29ded 100755 > --- a/tools/testing/selftests/drivers/net/psp.py > +++ b/tools/testing/selftests/drivers/net/psp.py > @@ -171,6 +171,38 @@ def dev_get_device_bad(cfg): > ksft_true(raised) > > > +def dev_set_crypt_offset(cfg): > + """ Set and get the crypt-offset """ > + _init_psp_dev(cfg) > + > + dev = cfg.pspnl.dev_get({'id': cfg.psp_dev_id}) > + orig = dev['crypt-offset'] > + cfg.pspnl.dev_set({"id": cfg.psp_dev_id, > + "crypt-offset": 5}) > + dev = cfg.pspnl.dev_get({'id': cfg.psp_dev_id}) > + ksft_eq(dev['crypt-offset'], 5) > + cfg.pspnl.dev_set({"id": cfg.psp_dev_id, > + "crypt-offset": orig}) > + dev = cfg.pspnl.dev_get({'id': cfg.psp_dev_id}) > + ksft_eq(dev['crypt-offset'], orig) > + > + > +def dev_set_spi_threshold(cfg): > + """ Set and get the spi-threshold """ > + _init_psp_dev(cfg) > + > + dev = cfg.pspnl.dev_get({'id': cfg.psp_dev_id}) > + orig = dev['spi-threshold'] > + cfg.pspnl.dev_set({"id": cfg.psp_dev_id, > + "spi-threshold": 10}) > + dev = cfg.pspnl.dev_get({'id': cfg.psp_dev_id}) > + ksft_eq(dev['spi-threshold'], 10) > + cfg.pspnl.dev_set({"id": cfg.psp_dev_id, > + "spi-threshold": orig}) > + dev = cfg.pspnl.dev_get({'id': cfg.psp_dev_id}) > + ksft_eq(dev['spi-threshold'], orig) These tests mainly verify that netlink works as intended. Not sure how much value that brings. Once crypt-offset requires bounds checking (say), such control ops functional tests may become more valuable. More interesting would be to see the effect on the datapath. E.g., a crypt-offset that actually leaves plaintext. Not sure how easy or hard this is, so don't take this as a requirement. But maybe something that achievable with PSP packetdrill (eventually)?