From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 724932DEA9D for ; Thu, 26 Mar 2026 02:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774492788; cv=none; b=Ivx+EpsC7bUdJjDF/tEZTSh9zgdu1qhGpyJEMw8VBHtEOJrUTAahJ4RmutccYFaWeoos9xZnbdVR2zoBIQKH7TerfTE5DTxa5x27ChCgmGkv1KfBDli/pSMNzKFQSRhwIffrKhj9MVmfl1KEXtcntuYHjLknCnxY9BhWcHWKW80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774492788; c=relaxed/simple; bh=oFuA9HJCp2JlyvrW6KQhqav2hsUc20F0Uqi2S8sqkmA=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=a4VOa5XiOFe5MWtcqHPni+PmnuiWHL/3TemslaYgG0oPIHnKffdR4zqMTM4bi3GmwMjhDLeXjRkvzGZJtIv7Es3W3Hk85Qq3PpJbWHxTjfWWI0YX3BR2RfO+iv17rTT7mC7tZV+I47EKyBVd421HpVgwcMkwsuzJ099ZHgyzbjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F5Jr3sSF; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F5Jr3sSF" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-64ad79dfb6eso580092d50.0 for ; Wed, 25 Mar 2026 19:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774492786; x=1775097586; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=OkKASDSS27GIMRV0i5mmWnYYUA/gqbOObp0Nx68p+B4=; b=F5Jr3sSFzM6qt6olpiFaPQHyixDsqRB6iQKwLiLCojGBU7Cej2RJLy1JdMogIsHxbG v09HU7rhILLB5bbM8hYZ6u40TAhpZ1Vx20Mz+Ui/pJv2nQXy39mYSGL7tqDBLCHYhlQG 6heOp93kwyN2mF2wHrYOj9AbZcbwS/yCqYHNIBzrNb8WWdXJs4Je5S/ue/6MJFi/JZSD gKoJfh2VRkvoXoKuzZ+dLMX9fVYiqwBy6cYr5Xdcn2qe6BG/5qNDebA7BGmqdr44cTuo gldphnvkoQOkpmGixirsSqv/a7mOpknwMFZkmCHGC9GXQ6Vro+16xs+m7Mt+dESYT58P MzIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774492786; x=1775097586; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OkKASDSS27GIMRV0i5mmWnYYUA/gqbOObp0Nx68p+B4=; b=lFSw1I03U1LaBm0kToBRR2u7kQnm55RAR2N6uHuBuo/r63mtX+bopHyxXwf1Ee1QNT rOP8uZDgQV8RigA8Ydp9XMGbaq3M9wXPwtpvVGq0y0b8Tx7ITXjWpLgOd1Fq3x3LqWPi yDjw+1m/qYQ6NPGavTAjxJP8OPM9Wi7HfX0+GtI32N3rVzcAmHTq1Tl5EqxM/msmtOmi 9fJUaBJYSbUYTacV2tLZ/r80VAyn9UYmgwFpU3xPXuVRt2qL3xowlKYy3I4RUdfw99wi ZupiDHfjuDkwyDayHDX0Ddf07AkbDLtz3GzW6ylmFWa48r95CLC5HGvJEclv5LTqHYRT jzjQ== X-Forwarded-Encrypted: i=1; AJvYcCU0xAeLrKE1EK4GuxIsg2pTAVBtvKlIjS0W9w1rA8cMpez9aa4VtJWiecQqMI8M3teJRwlE1YSTj3Alg60=@vger.kernel.org X-Gm-Message-State: AOJu0Yx94FiHregU5I8vrGjU9L0g73qPkOIC9Som1iNbcdCOK3V1NgKn GH6xFXRqdLYz4dpo8JU/gXmbLzIdAWkf0DuCXyM4p5qy5K7AuIWvzPWC X-Gm-Gg: ATEYQzziEb6w0h3qpEoAXXTbPpjfQhFxwILf/ZMRsQkpRfT+ZA1kC6tZrUE0+WQqKey 0DhDXh7cbN/tXh1NMZ01IXEA0nYmGTfbR5+05oPpQ1hqIrMwciKI1ohya4aq0a1BqzP9CLNub1g rIPUqnZXLMETmh9bkt4sKtab72xs8U4szzM+1IWEIFC/xZ3p+ayYLIvwJCY+KYwn5WkTXQAdcI2 v7DYiAh8slQKuOD5dWG1Hwii4aeqr4bk4n4wBS+7VRF5jm7OZZ672Uf78IJT6IjGAwJP5E6Xaak OSq6CcIwbJ0pdkIKZGmPT8BhyG1pjweGstGMpIOHC1nceUenGQVzZLmOozQW0NBqErZayXImeDm aPV9BiwYP6KD5woQF/o5/rqgfNVcTy9i3fBwnIv0m3RpbyGrmTKAPI7hMDmVGHr/rSvODilbrkr og0VUjCgq83TjEviqWHMIPB1vxKlHsJ/t+CBzAIOVpKhPtyhxFthgKWDY5FvNl5+Ja636Om1w11 VAc X-Received: by 2002:a05:690e:43c1:b0:64e:9dc7:90ae with SMTP id 956f58d0204a3-64ee612f985mr3789416d50.43.1774492786528; Wed, 25 Mar 2026 19:39:46 -0700 (PDT) Received: from gmail.com (180.134.85.34.bc.googleusercontent.com. [34.85.134.180]) by smtp.gmail.com with UTF8SMTPSA id 956f58d0204a3-64ef6c08f2esm868428d50.14.2026.03.25.19.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 19:39:45 -0700 (PDT) Date: Wed, 25 Mar 2026 22:39:45 -0400 From: Willem de Bruijn To: Jakub Kicinski , Qingfang Deng Cc: linux-ppp@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , David Ahern , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Fietkau , Willem de Bruijn Message-ID: In-Reply-To: <20260325165910.5bd7416c@kernel.org> References: <20260305013852.3769-1-dqfext@gmail.com> <20260306170411.49912ae1@kernel.org> <20260309140127.465b6ccd@kernel.org> <20260325165910.5bd7416c@kernel.org> Subject: Re: [PATCH net-next v5] net: pppoe: implement GRO/GSO support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Jakub Kicinski wrote: > On Wed, 25 Mar 2026 17:23:39 +0800 Qingfang Deng wrote: > > > > I haven't written a kselftest before. What tests should I include? > > > > > > > > I think I can add a local ppp server and client over veth, and test > > > > the connection with ping and iperf3. > > > > > > We have tools/testing/selftests/drivers/net/gro.c and associated Python > > > test. (note I have ambiguous feelings about adding ppp cases to this > > > file vs creating a new test, adding Willem to CC maybe he has some > > > guidance) > > > > He hasn't replied. What do you think? > > He probably missed the mid-thread email. Proceed with whatever you feel > makes sense. Sorry I missed this. It's hard to say without seeing the code. Perhaps code it up as an extension to gro.c. If the code changes are manageable, send that. Else, consider moving it into a stand-alone test.