From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f49.google.com (mail-yx1-f49.google.com [74.125.224.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B09B93B2FD2 for ; Fri, 1 May 2026 13:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777643607; cv=none; b=PiF28E38T53Akj4azzL5hQiZFquygUKWvFyN6BZYOWuNrFCWE7NHgDKEm2GtPiJX4n3UzbzGKDT2beU6tZ/mUs+LLxmPlfdRcFvUAjZrwJu5eSknbHXqtO0iIgOfhBtzIWtLYUN23DC1xjonKWw3NsQBIC0CYCltM+70EKZm8II= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777643607; c=relaxed/simple; bh=MefHtGDr3veSG4g4fudZER9OlKLeoj41zMvLE0mmBWg=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=pvsgbBs8hFXU0eoBnMkW59UjJpOL2PM3cI5V6vxeGpzYp20FtvemTZfcXaelCkGMWoImlSrU2NIjcAO+yzo5p6YmSHnx2tJ6I84MdMqO+kwcTieG3YMkjEWkQmfmyT1Ui+WuD962VFhPM4FZTTWsqFTbxjkzeZht0lIcnF4PucM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SIfmWqJ2; arc=none smtp.client-ip=74.125.224.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SIfmWqJ2" Received: by mail-yx1-f49.google.com with SMTP id 956f58d0204a3-654672a6d68so2057952d50.0 for ; Fri, 01 May 2026 06:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777643606; x=1778248406; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=B26lq8ihVexFKRPs2ffz6ggzVLhTsTx6fPgR3cmx4JI=; b=SIfmWqJ2kaG5UiCP7MnGKCMbaqM/E+vAqQuO9imPzSIoGx6vZoC9tBolwZurpnvnXj /CRrsW6pSChxkw6FsYtKqyTAfABgwFtlw+ZQBAcaIjrb3YMtZ4+qRJvCBlObW/tWiSuV ohFm2qmi2ecyah3cESY3e2gjggwn0ylGCPZ7jby3us1GhecxrbwlMf2FY8uh0a/0Vj7k zIUAj6AkZhy8SmaGQRJ0C/JG7SpXNaGl+DZJhJuo6P9XtlG24aWxoB1D0w+u7dEtzUjc kS9g0+ye41hHrCDpCxqTHwi4wq1Yy/V1t3ljlOBusx5oNHcT3zlMOAvrEkblLuHIH3+n KSGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777643606; x=1778248406; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=B26lq8ihVexFKRPs2ffz6ggzVLhTsTx6fPgR3cmx4JI=; b=n707WJfH1BOdfaxHiOmj7TdpwlKHuwmpqccrrKbYZG71/xMHcQot4InqhFK/daOpO7 VlyulWELqc4Mo8NLYd5rYSwK6q+xTassU2jcqR/U0GsL7B8SDspce0GfqdtRBpSNaMG5 UTLN7Mc2Nu0PWkclcQi23pympsn01WxHptXzpSwQ8nbBvUKlcZAM6h6p7suxwVvgW8lk pMkG605OLSy+aGyaOlBXXdIr2KnUU0jATy+5fJus2DWdZBYxE7PStE6yvSVzWqm0rrg7 Xe62g7RDD+HSvI5Tdz29FbmLFNpUmqztoiTUlGRcKOTiacMM2AKNVV4eclz2n8MkyBh9 aCRA== X-Forwarded-Encrypted: i=1; AFNElJ9Umbma7ZkEHB3Y6OKAYivft7H6FtHitMDOOwrRqVPMSjH8uEdjDH07HWu2R3JMWMt8QLeIy/qexwQZadY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyxl8tz96ybVqxQHlMcfmCo8sSQ7a/fUYMXfj2pwQFpMIl/C98K zU0gMsx1zO/MI9VWHsNEiBBQvZNSkarwgYtDi1sVFP0w0tc/5kpeCKme X-Gm-Gg: AeBDievZumTjdiZZixDMRwbtDAAEl2W3kykpRn1KZOo6Ktq4ZAm5zxFS0KsrbUYANue qMU1HYuuwSdtufbrV9bf1UuBlVec/pVK4nB7/6YaGZQ6xRy6qP3GjFPrCtM5D+2sp6wENGKYsZZ CH/a+dIbxPWzXdfQtAV0fJHDC2RXQ/4uukWy8zuLIvBYv8mN58G/NZtP9FgSYvsAkUAj5OVrZpR YjqsDvDZukT54Rs42jhKxRJWifOGPOqbb4fRpBHRieo4uFmBSwaAU+usparQhvGZJUXx48qs0Rb sOE+I5MAui/CFRDleLTFMin0yoaNqmppF4SGHhTsfAGTjN6a9724oRl41WPmnNeHYJYxfNasjbV bdpyLIaoCEVFnpFMUyWAkovF0Hkc9J0Ptpo4vyjHJolRl0ND/wcnCX4+dC/Eu/IcY+gs0We4Xwg KDtgWXIlP1P+ZFrfcxWL5v9oy0A6r8kSlIhL+oir+13KDa/TPGypJbLGqWelEvVL58St3TsBApn GRkxBoN34SDtbY= X-Received: by 2002:a53:d14b:0:b0:657:a1d0:992b with SMTP id 956f58d0204a3-65c18f36c6bmr4396849d50.43.1777643605682; Fri, 01 May 2026 06:53:25 -0700 (PDT) Received: from gmail.com (172.235.85.34.bc.googleusercontent.com. [34.85.235.172]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-65c2e1d95a8sm1192890d50.9.2026.05.01.06.53.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 06:53:24 -0700 (PDT) Date: Fri, 01 May 2026 09:53:24 -0400 From: Willem de Bruijn To: David Carlier , daniel.zahka@gmail.com, kuba@kernel.org Cc: willemdebruijn.kernel@gmail.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, raeds@nvidia.com, kees@kernel.org, cratiu@nvidia.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Carlier , stable@vger.kernel.org Message-ID: In-Reply-To: <20260501130046.16008-1-devnexen@gmail.com> References: <20260430062033.20428-1-devnexen@gmail.com> <20260501130046.16008-1-devnexen@gmail.com> Subject: Re: [PATCH net v2] psp: strip variable-length PSP header in psp_dev_rcv() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit David Carlier wrote: > psp_dev_rcv() unconditionally removes a fixed PSP_ENCAP_HLEN, even > when psph->hdrlen indicates that the PSP header carries optional > fields. A frame whose PSP header advertises a non-zero VC or any > extension would therefore be silently mis-decapsulated: option bytes > would spill into the inner packet head and downstream parsing would > fail on a corrupted skb. > > Compute the full PSP header length from psph->hdrlen, pull the > optional bytes into the linear region, and strip the whole header > when decapsulating. Optional fields (VC, ...) are still ignored, > just discarded with the rest of the header instead of leaking. > crypt_offset and the VIRT flag are intentionally not validated here > - callers know their device's PSP implementation and can decide. > > Both in-tree callers gate on hardware-validated PSP, so this is a > correctness fix rather than a reachable corruption path under > current configurations. > > Fixes: 0eddb8023cee ("psp: provide decapsulation and receive helper for drivers") > Suggested-by: Daniel Zahka > Cc: stable@vger.kernel.org > Signed-off-by: David Carlier Reviewed-by: Willem de Bruijn