From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4549A231A23 for ; Tue, 7 Apr 2026 04:07:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775534869; cv=none; b=oXYtRM3Z9cgqCBmPg8BUG7qsxYwwvh6JFbGdXwwcLrGG+JjQPk4lUSkfv4iv2/r95EwHdPwFXCKuYk3uKMABxjEDxbVU3f9886z+noo8AWlhBOp5FwewBA97i9JGGWOOd6w3rmsZlnNLxg2YAr7J8hFXIkAl01NUbLrSatxj+Sk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775534869; c=relaxed/simple; bh=z/d26nUNEIld6JzIfDKNBmEnkO9f2aJaTVV3ZWZuPlo=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=VGIpswsLPBOL+3OHCn3XSJ1yBHDCMlaKnWV/aCieqskcpNFGCgwiwtufFfv1SW3onw1BwobSXubTF5LLAHCdWzPJYWx+KDbpwVaOyFW4AwYDqZ0JIyngC1TBr9yUziCvZlbyJy3g8QbDMaaGIKNPTUJfJDv/QGedOLg7nphjrVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=anXgkpm+; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="anXgkpm+" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-824c9da9928so3565418b3a.3 for ; Mon, 06 Apr 2026 21:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775534868; x=1776139668; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=z/d26nUNEIld6JzIfDKNBmEnkO9f2aJaTVV3ZWZuPlo=; b=anXgkpm+FBWR1Tr5DeQGJ8sO0Ae4iLQLgH1+XG/KE+92g7IGyfIvLB920WrZa5mhiU 6NeTvVXqo0q8KsktSS1gphKlRKtua4MTQmGko/uLQUf1MISuniQ5q8hm6MXMF00yQ0PM rxvYrtOfowjLuLE0TdqcoGK+Ge4cnYpQde27kcExmPCj+AbCT1ooQeBUT1Dq4xVduxRB qjKAsXLVgtZHjeysib6VkZkUK7dHQtXh8Ni9zz1Xm4SCJrvFpm4PNhrc96k9FBULePvw yKoyr2wNDyORP/js1TYqy+TyqOcIcJ2yLUkZaxI85ZVvlPunpTgvyVEBwLmCKUT4HoJj 1siQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775534868; x=1776139668; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z/d26nUNEIld6JzIfDKNBmEnkO9f2aJaTVV3ZWZuPlo=; b=eaDz+UtZTmz0erRgnleiaY82TqzY1vxEHwjTD9NjqvkNeXVngUhSdAeAYCiJdpJlqK Nm9SVHMeCb3Hu/mIHjyI/wgAzW17b6VQ2wpVmsU0aB4WdjEyEjcs7+wD6WbX1OBfAHkM 5SQilEGO70se9QLQYRWGBG+Cm3vWuJEcv+A98TRb4Q0MNi1R6/8pS226BlYodOBTEEOL g0F9skscG/gZ0xRabVPi6GY7BtdbBstfo2908WuQ5KVZh/WuJMLMPABLlfm+pykBPkvN okgK+xgh+xJ+nFOkEsCfaEgp+RbCqv0D8ZOJkjnAMWpw01ND2wsFYCGOByoqFG9MaF2N v04A== X-Forwarded-Encrypted: i=1; AJvYcCVlzJ7K35MWduiYmRKGCrnQFBrpf1KgavVJ/y/kKsbIkJlLpK6SzXRa8rgnLoNb7EP0MwHFtXQ0PqXSxcA=@vger.kernel.org X-Gm-Message-State: AOJu0YxEgdVWAr5HpeAyVS0nPWoC/qdxautWLXci4M6oF8cs1gpllDA9 ejzm4pXBM98Ghqbueca0K0yDwNnM57h8flGXroFnn9o9SW1azZeM/Hs/ZaG2YQ== X-Gm-Gg: AeBDiet9d6ILTxG9w9egSPXY2Sg4tH7a2p5ldNU3vUn76aENneqWuQWEXrNSqXIjBsc nXDwB3M+mfvxGqtyG7iVZsUy3HjhI8tCnZes3+CbBLJ1w2AqflfYWqmmQIev1MuGcJJFyd27mew ALLYiqkLBWRBr7Apwl8u4c4ug77+z4/GL4ACF/BdHxPVkkt0SUuDAFxW3+UPa43CO04zsSWCTZI 1D1BenrEP3Acsg813AC8cDtW2CciTPYx5Ttg9aJ7J5vTtICbf0PY911C6EbpeQYNqOgMJz1vjEg iN3QSiju9+aN5vA9acetaMO32q5y273u1weRmo0FpmJ8xWtlTcXEWmBnTzzyry7cG7QmDNBqXRa 2c5li4Vw3+OXfdWzggMEH8mmDkqFAJ546f6Uwm9tr0fJ103l1GNuacWFe2t6Zs0gN6PRCgzx13i h6uouq4fHD1Chi3zieXfO2ww== X-Received: by 2002:a05:6a00:4092:b0:82c:2155:5b6d with SMTP id d2e1a72fcca58-82d0da332bcmr13420506b3a.12.1775534867592; Mon, 06 Apr 2026 21:07:47 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9c41bc6sm16102423b3a.29.2026.04.06.21.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 21:07:46 -0700 (PDT) From: Ritesh Harjani (IBM) To: Adriano Vero , maddy@linux.ibm.com, mpe@ellerman.id.au Cc: npiggin@gmail.com, chleroy@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Adriano Vero Subject: Re: [PATCH] powerpc/fadump: Add timeout to RTAS busy-wait loops In-Reply-To: <20260406061542.22354-1-litaliano00.contact@gmail.com> Date: Tue, 07 Apr 2026 09:36:50 +0530 Message-ID: References: <20260406061542.22354-1-litaliano00.contact@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Adriano Vero writes: > The ibm,configure-kernel-dump RTAS call sites in > rtas_fadump_register(), rtas_fadump_unregister(), and > rtas_fadump_invalidate() polled indefinitely while firmware returned > a busy status. A misbehaving or hung firmware could stall these paths > forever, blocking fadump registration at boot or preventing clean > teardown. Was there an issue which you encountered? Can you share the details of the same please? > > Track the accumulated delay in a total_wait counter and bail out with > -ETIMEDOUT if it reaches RTAS_FADUMP_MAX_WAIT_MS (60 seconds) before > firmware signals completion. This follows the bounded busy-wait pattern > used in rtas-rtc.c. > > Signed-off-by: Adriano Vero