From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965758AbcHBM5g (ORCPT ); Tue, 2 Aug 2016 08:57:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39290 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965744AbcHBM5Q (ORCPT ); Tue, 2 Aug 2016 08:57:16 -0400 From: Jes Sorensen To: Baole Ni Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0955/1285] Replace numeric parameter like 0444 with macro References: <20160802120228.13716-1-baolex.ni@intel.com> Date: Tue, 02 Aug 2016 08:49:18 -0400 In-Reply-To: <20160802120228.13716-1-baolex.ni@intel.com> (Baole Ni's message of "Tue, 2 Aug 2016 20:02:28 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 02 Aug 2016 12:49:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Baole Ni writes: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- > drivers/staging/vt6656/main_usb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Excuse me, but why are you CC'ing everybody and their 217 cousins on these patches? The fact that someone had a patch applied in a directory close to this file within the last 3 years is not justification for spamming them with this. Jes