From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752078AbaKJUVk (ORCPT ); Mon, 10 Nov 2014 15:21:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47326 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbaKJUVj (ORCPT ); Mon, 10 Nov 2014 15:21:39 -0500 From: Jes Sorensen To: Chris Ruffin Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Larry Finger , Greg Kroah-Hartman Subject: Re: [PATCH] staging: rtl8723au: change typecast to match type returned by htons() References: <1415650025-16403-1-git-send-email-cmruffin@gmail.com> Date: Mon, 10 Nov 2014 15:21:30 -0500 In-Reply-To: <1415650025-16403-1-git-send-email-cmruffin@gmail.com> (Chris Ruffin's message of "Mon, 10 Nov 2014 15:07:05 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chris Ruffin writes: > Using a u16 pointer typecast for a result from htons() results in the following warning from sparse: > > drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36: warning: incorrect type in assignment (different base types) > drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36: expected unsigned short [unsigned] [short] [usertype] > drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36: got restricted __be16 [usertype] > > This patch fixes the issue by using an endian-specific typecast > that will always match the type returned by htons(). > > Signed-off-by: Chris Ruffin > --- > drivers/staging/rtl8723au/core/rtw_xmit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks fine to me Signed-off-by: Jes Sorensen > > diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c > index a0f7e27..44ef55c 100644 > --- a/drivers/staging/rtl8723au/core/rtw_xmit.c > +++ b/drivers/staging/rtl8723au/core/rtw_xmit.c > @@ -1276,7 +1276,7 @@ s32 rtw_put_snap23a(u8 *data, u16 h_proto) > snap->oui[0] = oui[0]; > snap->oui[1] = oui[1]; > snap->oui[2] = oui[2]; > - *(u16 *)(data + SNAP_SIZE) = htons(h_proto); > + *(__be16 *)(data + SNAP_SIZE) = htons(h_proto); > return SNAP_SIZE + sizeof(u16); > }