From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751405AbaK1Mfd (ORCPT ); Fri, 28 Nov 2014 07:35:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48744 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbaK1Mfc (ORCPT ); Fri, 28 Nov 2014 07:35:32 -0500 From: Jes Sorensen To: Athira Lekshmi Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, ruchandani.tina@gmail.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Drivers:staging:rtl8723au:core: Fixed checkpatch error References: <1417176974-18604-1-git-send-email-andnlnbn18@gmail.com> Date: Fri, 28 Nov 2014 07:35:23 -0500 In-Reply-To: <1417176974-18604-1-git-send-email-andnlnbn18@gmail.com> (Athira Lekshmi's message of "Fri, 28 Nov 2014 17:46:14 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Athira Lekshmi writes: > Fixed the checkpatch error: > ERROR: spaces required around that '>' > > Signed-off-by: Athira Lekshmi > --- > drivers/staging/rtl8723au/core/rtw_cmd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c b/drivers/staging/rtl8723au/core/rtw_cmd.c > index 44eae8e..9f1cdd4 100644 > --- a/drivers/staging/rtl8723au/core/rtw_cmd.c > +++ b/drivers/staging/rtl8723au/core/rtw_cmd.c > @@ -960,7 +960,7 @@ static void traffic_status_watchdog(struct rtw_adapter *padapter) > /* check traffic for powersaving. */ > if (((pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod + > pmlmepriv->LinkDetectInfo.NumTxOkInPeriod) > 8) || > - pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod >2) > + pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 2) > bEnterPS = false; > else > bEnterPS = true; NACK - I already stated this! Making the line longer than 80 characters is worse then the 'problem' this fixes. Jes