From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Greg Donald <gdonald@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linux.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8723au: Fix return is not a function, parentheses are not required error
Date: Wed, 03 Sep 2014 14:21:38 +0200 [thread overview]
Message-ID: <wrfjoauwdhd9.fsf@redhat.com> (raw)
In-Reply-To: <1409532379-1697-1-git-send-email-gdonald@gmail.com> (Greg Donald's message of "Sun, 31 Aug 2014 19:46:19 -0500")
Greg Donald <gdonald@gmail.com> writes:
> Fix checkpatch.pl return is not a function, parentheses are not required error
>
> Signed-off-by: Greg Donald <gdonald@gmail.com>
> ---
> drivers/staging/rtl8723au/include/osdep_service.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Yes please!
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> diff --git a/drivers/staging/rtl8723au/include/osdep_service.h
> b/drivers/staging/rtl8723au/include/osdep_service.h
> index 51a5d7b..dedb418 100644
> --- a/drivers/staging/rtl8723au/include/osdep_service.h
> +++ b/drivers/staging/rtl8723au/include/osdep_service.h
> @@ -54,7 +54,7 @@ struct rtw_queue {
>
> static inline struct list_head *get_list_head(struct rtw_queue *queue)
> {
> - return (&queue->queue);
> + return &queue->queue;
> }
>
> static inline int rtw_netif_queue_stopped(struct net_device *pnetdev)
prev parent reply other threads:[~2014-09-03 12:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 0:46 [PATCH] drivers: staging: rtl8723au: Fix return is not a function, parentheses are not required error Greg Donald
2014-09-03 12:21 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjoauwdhd9.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gdonald@gmail.com \
--cc=gregkh@linux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox