From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753152AbdC2PtF (ORCPT ); Wed, 29 Mar 2017 11:49:05 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:33385 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752016AbdC2Prc (ORCPT ); Wed, 29 Mar 2017 11:47:32 -0400 From: jes.sorensen@gmail.com X-Google-Original-From: Jes.Sorensen@gmail.com To: Gioh Kim Cc: neilb@suse.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mdadm.c: fix compile error "switch condition has boolean value" References: <1490780434-8720-1-git-send-email-gi-oh.kim@profitbricks.com> <1490780434-8720-2-git-send-email-gi-oh.kim@profitbricks.com> Date: Wed, 29 Mar 2017 11:47:28 -0400 In-Reply-To: <1490780434-8720-2-git-send-email-gi-oh.kim@profitbricks.com> (Gioh Kim's message of "Wed, 29 Mar 2017 11:40:34 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gioh Kim writes: > Remove a boolean expression in switch condition > to prevent compile error of some compilers. Please be specific, which compile is unable to handle this? > Signed-off-by: Gioh Kim > --- > mdadm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mdadm.c b/mdadm.c > index 08ddcab..a98a051 100644 > --- a/mdadm.c > +++ b/mdadm.c > @@ -1905,11 +1905,11 @@ static int misc_list(struct mddev_dev *devlist, > rv |= SetAction(dv->devname, c->action); > continue; > } > - switch(dv->devname[0] == '/') { > - case 0: > + switch(dv->devname[0]) { > + default: > mdfd = open_dev(dv->devname); > if (mdfd >= 0) break; > - case 1: > + case '/': > mdfd = open_mddev(dv->devname, 1); > } > if (mdfd>=0) { While I agree the original code is ugly, I am not convinced your replacement is a lot prettier. Thanks, Jes