* [PATCH] Staging: rtl8723au: Remove function rtw_enqueue_{recvbuf23a/recvbuf23a_to_head}
@ 2016-03-26 6:24 Bhumika Goyal
2016-03-28 4:10 ` Julian Calaby
2016-03-29 15:19 ` Jes Sorensen
0 siblings, 2 replies; 3+ messages in thread
From: Bhumika Goyal @ 2016-03-26 6:24 UTC (permalink / raw)
To: Larry.Finger, gregkh
Cc: Jes.Sorensen, joe, linux-wireless, devel, linux-kernel,
Bhumika Goyal
The functions rtw_enqueue_recvbuf23a and rtw_enqueue_recvbuf23a_to_head
are never used anywhere in the kernel. So, remove their definition and
prototype.
Grepped to find occurences.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/staging/rtl8723au/core/rtw_recv.c | 25 -------------------------
drivers/staging/rtl8723au/include/rtw_recv.h | 2 --
2 files changed, 27 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b/drivers/staging/rtl8723au/core/rtw_recv.c
index 989ed07..150dabc 100644
--- a/drivers/staging/rtl8723au/core/rtw_recv.c
+++ b/drivers/staging/rtl8723au/core/rtw_recv.c
@@ -211,31 +211,6 @@ u32 rtw_free_uc_swdec_pending_queue23a(struct rtw_adapter *adapter)
return cnt;
}
-int rtw_enqueue_recvbuf23a_to_head(struct recv_buf *precvbuf, struct rtw_queue *queue)
-{
- spin_lock_bh(&queue->lock);
-
- list_del_init(&precvbuf->list);
- list_add(&precvbuf->list, get_list_head(queue));
-
- spin_unlock_bh(&queue->lock);
-
- return _SUCCESS;
-}
-
-int rtw_enqueue_recvbuf23a(struct recv_buf *precvbuf, struct rtw_queue *queue)
-{
- unsigned long irqL;
-
- spin_lock_irqsave(&queue->lock, irqL);
-
- list_del_init(&precvbuf->list);
-
- list_add_tail(&precvbuf->list, get_list_head(queue));
- spin_unlock_irqrestore(&queue->lock, irqL);
- return _SUCCESS;
-}
-
struct recv_buf *rtw_dequeue_recvbuf23a (struct rtw_queue *queue)
{
unsigned long irqL;
diff --git a/drivers/staging/rtl8723au/include/rtw_recv.h b/drivers/staging/rtl8723au/include/rtw_recv.h
index dc784be..85a5edb 100644
--- a/drivers/staging/rtl8723au/include/rtw_recv.h
+++ b/drivers/staging/rtl8723au/include/rtw_recv.h
@@ -279,8 +279,6 @@ int rtw_enqueue_recvframe23a(struct recv_frame *precvframe, struct rtw_queue *qu
u32 rtw_free_uc_swdec_pending_queue23a(struct rtw_adapter *adapter);
-int rtw_enqueue_recvbuf23a_to_head(struct recv_buf *precvbuf, struct rtw_queue *queue);
-int rtw_enqueue_recvbuf23a(struct recv_buf *precvbuf, struct rtw_queue *queue);
struct recv_buf *rtw_dequeue_recvbuf23a(struct rtw_queue *queue);
void rtw_reordering_ctrl_timeout_handler23a(unsigned long pcontext);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: rtl8723au: Remove function rtw_enqueue_{recvbuf23a/recvbuf23a_to_head}
2016-03-26 6:24 [PATCH] Staging: rtl8723au: Remove function rtw_enqueue_{recvbuf23a/recvbuf23a_to_head} Bhumika Goyal
@ 2016-03-28 4:10 ` Julian Calaby
2016-03-29 15:19 ` Jes Sorensen
1 sibling, 0 replies; 3+ messages in thread
From: Julian Calaby @ 2016-03-28 4:10 UTC (permalink / raw)
To: Bhumika Goyal
Cc: Larry Finger, Greg KH, Jes Sorensen, Joe Perches, linux-wireless,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Hi All,
On Sat, Mar 26, 2016 at 5:24 PM, Bhumika Goyal <bhumirks@gmail.com> wrote:
> The functions rtw_enqueue_recvbuf23a and rtw_enqueue_recvbuf23a_to_head
> are never used anywhere in the kernel. So, remove their definition and
> prototype.
> Grepped to find occurences.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Looks right to me.
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
> ---
> drivers/staging/rtl8723au/core/rtw_recv.c | 25 -------------------------
> drivers/staging/rtl8723au/include/rtw_recv.h | 2 --
> 2 files changed, 27 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b/drivers/staging/rtl8723au/core/rtw_recv.c
> index 989ed07..150dabc 100644
> --- a/drivers/staging/rtl8723au/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723au/core/rtw_recv.c
> @@ -211,31 +211,6 @@ u32 rtw_free_uc_swdec_pending_queue23a(struct rtw_adapter *adapter)
> return cnt;
> }
>
> -int rtw_enqueue_recvbuf23a_to_head(struct recv_buf *precvbuf, struct rtw_queue *queue)
> -{
> - spin_lock_bh(&queue->lock);
> -
> - list_del_init(&precvbuf->list);
> - list_add(&precvbuf->list, get_list_head(queue));
> -
> - spin_unlock_bh(&queue->lock);
> -
> - return _SUCCESS;
> -}
> -
> -int rtw_enqueue_recvbuf23a(struct recv_buf *precvbuf, struct rtw_queue *queue)
> -{
> - unsigned long irqL;
> -
> - spin_lock_irqsave(&queue->lock, irqL);
> -
> - list_del_init(&precvbuf->list);
> -
> - list_add_tail(&precvbuf->list, get_list_head(queue));
> - spin_unlock_irqrestore(&queue->lock, irqL);
> - return _SUCCESS;
> -}
> -
> struct recv_buf *rtw_dequeue_recvbuf23a (struct rtw_queue *queue)
> {
> unsigned long irqL;
> diff --git a/drivers/staging/rtl8723au/include/rtw_recv.h b/drivers/staging/rtl8723au/include/rtw_recv.h
> index dc784be..85a5edb 100644
> --- a/drivers/staging/rtl8723au/include/rtw_recv.h
> +++ b/drivers/staging/rtl8723au/include/rtw_recv.h
> @@ -279,8 +279,6 @@ int rtw_enqueue_recvframe23a(struct recv_frame *precvframe, struct rtw_queue *qu
>
> u32 rtw_free_uc_swdec_pending_queue23a(struct rtw_adapter *adapter);
>
> -int rtw_enqueue_recvbuf23a_to_head(struct recv_buf *precvbuf, struct rtw_queue *queue);
> -int rtw_enqueue_recvbuf23a(struct recv_buf *precvbuf, struct rtw_queue *queue);
> struct recv_buf *rtw_dequeue_recvbuf23a(struct rtw_queue *queue);
>
> void rtw_reordering_ctrl_timeout_handler23a(unsigned long pcontext);
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: rtl8723au: Remove function rtw_enqueue_{recvbuf23a/recvbuf23a_to_head}
2016-03-26 6:24 [PATCH] Staging: rtl8723au: Remove function rtw_enqueue_{recvbuf23a/recvbuf23a_to_head} Bhumika Goyal
2016-03-28 4:10 ` Julian Calaby
@ 2016-03-29 15:19 ` Jes Sorensen
1 sibling, 0 replies; 3+ messages in thread
From: Jes Sorensen @ 2016-03-29 15:19 UTC (permalink / raw)
To: Bhumika Goyal
Cc: Larry.Finger, gregkh, joe, linux-wireless, devel, linux-kernel
Bhumika Goyal <bhumirks@gmail.com> writes:
> The functions rtw_enqueue_recvbuf23a and rtw_enqueue_recvbuf23a_to_head
> are never used anywhere in the kernel. So, remove their definition and
> prototype.
> Grepped to find occurences.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/staging/rtl8723au/core/rtw_recv.c | 25 -------------------------
> drivers/staging/rtl8723au/include/rtw_recv.h | 2 --
> 2 files changed, 27 deletions(-)
Looks reasonable to me.
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes
> diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b/drivers/staging/rtl8723au/core/rtw_recv.c
> index 989ed07..150dabc 100644
> --- a/drivers/staging/rtl8723au/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723au/core/rtw_recv.c
> @@ -211,31 +211,6 @@ u32 rtw_free_uc_swdec_pending_queue23a(struct rtw_adapter *adapter)
> return cnt;
> }
>
> -int rtw_enqueue_recvbuf23a_to_head(struct recv_buf *precvbuf, struct rtw_queue *queue)
> -{
> - spin_lock_bh(&queue->lock);
> -
> - list_del_init(&precvbuf->list);
> - list_add(&precvbuf->list, get_list_head(queue));
> -
> - spin_unlock_bh(&queue->lock);
> -
> - return _SUCCESS;
> -}
> -
> -int rtw_enqueue_recvbuf23a(struct recv_buf *precvbuf, struct rtw_queue *queue)
> -{
> - unsigned long irqL;
> -
> - spin_lock_irqsave(&queue->lock, irqL);
> -
> - list_del_init(&precvbuf->list);
> -
> - list_add_tail(&precvbuf->list, get_list_head(queue));
> - spin_unlock_irqrestore(&queue->lock, irqL);
> - return _SUCCESS;
> -}
> -
> struct recv_buf *rtw_dequeue_recvbuf23a (struct rtw_queue *queue)
> {
> unsigned long irqL;
> diff --git a/drivers/staging/rtl8723au/include/rtw_recv.h b/drivers/staging/rtl8723au/include/rtw_recv.h
> index dc784be..85a5edb 100644
> --- a/drivers/staging/rtl8723au/include/rtw_recv.h
> +++ b/drivers/staging/rtl8723au/include/rtw_recv.h
> @@ -279,8 +279,6 @@ int rtw_enqueue_recvframe23a(struct recv_frame *precvframe, struct rtw_queue *qu
>
> u32 rtw_free_uc_swdec_pending_queue23a(struct rtw_adapter *adapter);
>
> -int rtw_enqueue_recvbuf23a_to_head(struct recv_buf *precvbuf, struct rtw_queue *queue);
> -int rtw_enqueue_recvbuf23a(struct recv_buf *precvbuf, struct rtw_queue *queue);
> struct recv_buf *rtw_dequeue_recvbuf23a(struct rtw_queue *queue);
>
> void rtw_reordering_ctrl_timeout_handler23a(unsigned long pcontext);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-29 15:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-26 6:24 [PATCH] Staging: rtl8723au: Remove function rtw_enqueue_{recvbuf23a/recvbuf23a_to_head} Bhumika Goyal
2016-03-28 4:10 ` Julian Calaby
2016-03-29 15:19 ` Jes Sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox