From: Adam Megacz <megacz@cs.berkeley.edu>
To: linux-kernel@vger.kernel.org
Subject: Re: OpenAFS gatekeepers request addition of AFS_SUPER_MAGIC to magic.h
Date: Fri, 29 Dec 2006 18:09:27 -0800 [thread overview]
Message-ID: <x3wt4a16eg.fsf@nowhere.com> (raw)
In-Reply-To: 20061230004542.GJ24675@kenobi.snowman.net
Drat. Diffed in the wrong direction. Yes, you're right.
- a
Stephen Frost <sfrost@snowman.net> writes:
> * Adam Megacz (megacz@cs.berkeley.edu) wrote:
>> --- include/linux/magic.h 2006-12-29 15:48:50.000000000 -0800
>> +++ include/linux/magic.h 2006-11-29 13:57:37.000000000 -0800
>> @@ -3,7 +3,6 @@
>>
>> #define ADFS_SUPER_MAGIC 0xadf5
>> #define AFFS_SUPER_MAGIC 0xadff
>> -#define AFS_SUPER_MAGIC 0x5346414F
>> #define AUTOFS_SUPER_MAGIC 0x0187
>> #define CODA_SUPER_MAGIC 0x73757245
>> #define EFS_SUPER_MAGIC 0x414A53
>
> Wouldn't you want a patch which *adds* it, rather than one which
> *removes* it...?
>
> Thanks,
>
> Stephen
--
PGP/GPG: 5C9F F366 C9CF 2145 E770 B1B8 EFB1 462D A146 C380
next prev parent reply other threads:[~2006-12-30 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-29 23:56 OpenAFS gatekeepers request addition of AFS_SUPER_MAGIC to magic.h Adam Megacz
2006-12-30 0:45 ` Stephen Frost
2006-12-30 2:09 ` Adam Megacz [this message]
2006-12-30 9:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x3wt4a16eg.fsf@nowhere.com \
--to=megacz@cs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox