From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbbGPOqI (ORCPT ); Thu, 16 Jul 2015 10:46:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42797 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752314AbbGPOqG (ORCPT ); Thu, 16 Jul 2015 10:46:06 -0400 From: Jeff Moyer To: Jens Axboe Cc: , , Subject: Re: [PATCH 1/3] block: have drivers use blk_queue_max_discard_sectors() References: <1436899703-31966-1-git-send-email-axboe@fb.com> <1436899703-31966-2-git-send-email-axboe@fb.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Thu, 16 Jul 2015 10:46:03 -0400 In-Reply-To: <1436899703-31966-2-git-send-email-axboe@fb.com> (Jens Axboe's message of "Tue, 14 Jul 2015 12:48:21 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jens Axboe writes: > Some drivers use it now, others just set the limits field manually. > But in preparation for splitting this into a hard and soft limit, > ensure that they all call the proper function for setting the hw > limit for discards. > > Signed-off-by: Jens Axboe Some of those >>9's look misplaced, but you didn't introduce that, so... Reviewed-by: Jeff Moyer