From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753126Ab1AXTiJ (ORCPT ); Mon, 24 Jan 2011 14:38:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27538 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752800Ab1AXTiH (ORCPT ); Mon, 24 Jan 2011 14:38:07 -0500 From: Jeff Moyer To: Jens Axboe Cc: "linux-kernel\@vger.kernel.org" , "hch\@infradead.org" , Shaohua Li Subject: Re: [PATCH 10/10] fs: make aio plug References: <1295659049-2688-1-git-send-email-jaxboe@fusionio.com> <1295659049-2688-11-git-send-email-jaxboe@fusionio.com> <4D3DCE5D.9090708@fusionio.com> <4D3DD184.4040700@fusionio.com> <4D3DD39C.9000208@fusionio.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Mon, 24 Jan 2011 14:38:01 -0500 In-Reply-To: <4D3DD39C.9000208@fusionio.com> (Jens Axboe's message of "Mon, 24 Jan 2011 20:31:40 +0100") Message-ID: User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jens Axboe writes: >>>> As for the iput, I don't think you will get the final iput here, since >>>> you've just scheduled I/O against the file. >>> >>> Good point, so the original comment is moot - it wont make a difference. >>> Still, may not be a bad idea to do the freeing first. I was sort-of >>> hoping to be able to kill the batching in fs/aio.c completely, though... >> >> Yes, that's what I meant above when I said I agreed with the TODO item. >> Go ahead and nuke it. > > Will do, if you promise to help test it :-) Yeah, I'll sign up to do some testing. Cheers, Jeff