From: Jeff Moyer <jmoyer@redhat.com>
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@fb.com>,
Ming Lin <ming.l@ssi.samsung.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Hannes Reinecke <hare@suse.com>,
Mike Christie <mchristi@redhat.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] skd: fix assert typo
Date: Mon, 12 Sep 2016 13:43:36 -0400 [thread overview]
Message-ID: <x49r38pj9o7.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20160830102634.22627-1-eric.engestrom@imgtec.com> (Eric Engestrom's message of "Tue, 30 Aug 2016 11:26:32 +0100")
Eric Engestrom <eric.engestrom@imgtec.com> writes:
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
> drivers/block/skd_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> index 3822eae..94a7425 100644
> --- a/drivers/block/skd_main.c
> +++ b/drivers/block/skd_main.c
> @@ -1905,7 +1905,7 @@ static void skd_send_internal_skspcl(struct skd_device *skdev,
> break;
>
> default:
> - SKD_ASSERT("Don't know what to send");
> + SKD_ASSERT(!"Don't know what to send");
That's perverse. Just change SKD_ASSERT to pr_err and Robert's your
mother's brother.
Cheers,
Jeff
next prev parent reply other threads:[~2016-09-12 17:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 10:26 [PATCH] skd: fix assert typo Eric Engestrom
2016-09-12 17:43 ` Jeff Moyer [this message]
2016-09-16 9:31 ` [PATCH v2] " Eric Engestrom
2016-09-16 11:59 ` Johannes Thumshirn
2016-09-16 12:40 ` Jeff Moyer
2016-09-16 13:06 ` Eric Engestrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49r38pj9o7.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=eric.engestrom@imgtec.com \
--cc=hare@suse.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=ming.l@ssi.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox