Re: [PATCH] skd: fix assert typo

Jeff Moyer
2016-09-12T17:43:48Z

Eric Engestrom <eric.engestrom@imgtec.com> writes:

> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
> drivers/block/skd_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> index 3822eae..94a7425 100644
> --- a/drivers/block/skd_main.c
> +++ b/drivers/block/skd_main.c
> @@ -1905,7 +1905,7 @@ static void skd_send_internal_skspcl(struct skd_device *skdev,
> break;
>
> default:
> - SKD_ASSERT("Don't know what to send");
> + SKD_ASSERT(!"Don't know what to send");

That's perverse. Just change SKD_ASSERT to pr_err and Robert's your
mother's brother.

Cheers,
Jeff