Linux 2.4.25-pre7

Linux 2.4.25-pre7

[Marcelo Tosatti]

Hi,

Here goes -pre number 7 of 2.4.25 series.

It contains a bunch of architecture-specific updates (ia64, ppc, mips),
JFS and XFS updates, bugfix for big (>128GB) FAT filesystem corruption,
amongst others.

About 2.4 freeze:

The planned freeze during 2.4.26 can happen only for 2.4.27.

There are a few bad problems I'm aware of which still need to be fixed
(aic7xxx needs to be updated, modular IDE has some problems, etc). Those
should get fixed during 2.4.26-pre.

Please help testing! :)


Summary of changes from v2.4.25-pre6 to v2.4.25-pre7
============================================

<alex.williamson:hp.com>:
  o ia64: sba_iommu update
  o ia64: sba_iommu: use memparse, long double

<bjorn.helgaas:hp.com>:
  o ia64: work around a menuconfig bug
  o ia64: Fix system type selection to workaround menuconfig bug (select "HP", get "HP-simulator").
  o ia64: Fix broken merge (remove mmu_gathers[] defn)
  o ia64: Skip zero-length resources in PCI root bridge _CRS
  o ia64: sba_iommu: print note about reserving IOVA space for agpgart
  o ia64: Export acpi_hp_csr_space() for modular agpgart
  o ia64: Add acpi_register_irq() interface

<grundler:parisc-linux.org>:
  o obmouse driver for HP OB600 C/CT laptop

<jet:gyve.org>:
  o Fix hfs oops

<marcelo:logos.cnet>:
  o Changed EXTRAVERSION to -pre7

Adrian Bunk:
  o simplify PARPORT_PC_PCMCIA dependencies

Arun Sharma:
  o ia64: ia32 sigaltstack() fix

Atul Mukker:
  o megaraid2 update

Bjorn Helgaas:
  o ia64 HP iommu: add "sx1000" detection (no functional change)

Dave Kleikamp:
  o JFS: Avoid segfault when dirty inodes are written on readonly mount
  o JFS: Creating large xattr lists may cause BUG

Dean Roehrich:
  o [XFS] In xfs_bulkstat, we need to do the readahead loop always

Eric Sandeen:
  o [XFS] Fix for large allocation groups, so that extent sizes will not overflow pagebuf lengths.

Hirofumi Ogawa:
  o FAT: Support large partition (> 128GB)

Jack Steiner:
  o ia64: fix ia64_ctx.lock deadlock

Keith Owens:
  o ia64: fix deadlock in ia64_mca_cmc_int_caller()
  o ia64: Avoid double clear of CMC/CPE records

Manfred Spraul:
  o ldt optimization

Martin Hicks:
  o ia64: Move mmu_gathers[] to local_cpu_data on ia64 (only ia64-specific bits)

Matthew Wilcox:
  o ia64: Add generic RAID xor routines with prefetch

Petr Vandrovec:
  o Deep stack usage in ncpfs

Ralf Bächle:
  o MIPS updates
  o MIPS/DECstation video drivers update
  o Turbochannel driver updates

Rik van Riel:
  o some more fixes for fs/inode.c inode reclaiming changes

Seth Rohit:
  o ia64: hugetlb support (ia64-specific parts)

Stéphane Eranian:
  o ia64: Fix PFM_WRITE_PMCS failure in system-wide mode when PMC12 is zero

Tom Rini:
  o PPC32: Fix finding the MAC address on Motorola MBX860
  o PPC32: Fix the todc definitions for mc146818

Tony Luck:
  o ia64: enable recovery from TLB errors

Re: Linux 2.4.25-pre7

[Udo A. Steinberg]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

On Fri, 23 Jan 2004 16:58:24 -0200 (BRST) Marcelo Tosatti (MT) wrote:

MT> Here goes -pre number 7 of 2.4.25 series.
MT> 
MT> About 2.4 freeze:
MT> The planned freeze during 2.4.26 can happen only for 2.4.27.

Do you have any plans to merge cryptoloop into 2.4. before the freeze?

-Udo.

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Linux 2.4.25-pre7

[Marcelo Tosatti]

On Fri, 23 Jan 2004, Udo A. Steinberg wrote:

> On Fri, 23 Jan 2004 16:58:24 -0200 (BRST) Marcelo Tosatti (MT) wrote:
>
> MT> Here goes -pre number 7 of 2.4.25 series.
> MT>
> MT> About 2.4 freeze:
> MT> The planned freeze during 2.4.26 can happen only for 2.4.27.
>
> Do you have any plans to merge cryptoloop into 2.4. before the freeze?

Udo,

I have no plans to do it.

Re: Linux 2.4.25-pre7

[Rafał 'rmrmg' Roszak]

[-- Attachment #1: Type: text/plain, Size: 2638 bytes --]

begin  Marcelo Tosatti <marcelo.tosatti@cyclades.com> quote:

> Here goes -pre number 7 of 2.4.25 series.


#v+

if [ -r System.map ]; then /sbin/depmod -ae -F System.map  2.4.25-pre7;
fi depmod: *** Unresolved symbols in
/lib/modules/2.4.25-pre7/kernel/drivers/media/video/bttv.o depmod: 
i2c_master_recv_R43f1fb54 depmod: 	i2c_bit_add_bus_Rfffabe1b
depmod: 	i2c_bit_del_bus_R1100f0f3
depmod: 	i2c_master_send_Race048b9
depmod: *** Unresolved symbols in
/lib/modules/2.4.25-pre7/kernel/drivers/media/video/msp3400.o depmod: 
i2c_detach_client_R9f8e12b7 depmod: 	i2c_attach_client_R55afad1a
depmod: 	i2c_transfer_Rbd54062b
depmod: 	i2c_del_driver_Rcca56a4c
depmod: 	i2c_probe_Rb60c5768
depmod: 	i2c_add_driver_Rcb6691c5
depmod: 	i2c_master_send_Race048b9
depmod: *** Unresolved symbols in
/lib/modules/2.4.25-pre7/kernel/drivers/media/video/tda7432.o depmod: 
i2c_detach_client_R9f8e12b7 depmod: 	i2c_attach_client_R55afad1a
depmod: 	i2c_del_driver_Rcca56a4c
depmod: 	i2c_probe_Rb60c5768
depmod: 	i2c_add_driver_Rcb6691c5
depmod: 	i2c_master_send_Race048b9
depmod: *** Unresolved symbols in
/lib/modules/2.4.25-pre7/kernel/drivers/media/video/tda9875.o depmod: 
i2c_detach_client_R9f8e12b7 depmod: 	i2c_attach_client_R55afad1a
depmod: 	i2c_transfer_Rbd54062b
depmod: 	i2c_del_driver_Rcca56a4c
depmod: 	i2c_probe_Rb60c5768
depmod: 	i2c_add_driver_Rcb6691c5
depmod: 	i2c_master_send_Race048b9
depmod: *** Unresolved symbols in
/lib/modules/2.4.25-pre7/kernel/drivers/media/video/tda9887.o depmod: 
i2c_detach_client_R9f8e12b7 depmod: 	i2c_attach_client_R55afad1a
depmod: 	i2c_del_driver_Rcca56a4c
depmod: 	i2c_probe_Rb60c5768
depmod: 	i2c_add_driver_Rcb6691c5
depmod: 	i2c_master_send_Race048b9
depmod: *** Unresolved symbols in
/lib/modules/2.4.25-pre7/kernel/drivers/media/video/tuner.o depmod: 
i2c_detach_client_R9f8e12b7 depmod: 	i2c_master_recv_R43f1fb54
depmod: 	i2c_attach_client_R55afad1a
depmod: 	i2c_del_driver_Rcca56a4c
depmod: 	i2c_probe_Rb60c5768
depmod: 	i2c_add_driver_Rcb6691c5
depmod: 	i2c_master_send_Race048b9
depmod: *** Unresolved symbols in
/lib/modules/2.4.25-pre7/kernel/drivers/media/video/tvaudio.o depmod: 
i2c_detach_client_R9f8e12b7 depmod: 	i2c_master_recv_R43f1fb54
depmod: 	i2c_attach_client_R55afad1a
depmod: 	i2c_transfer_Rbd54062b
depmod: 	i2c_del_driver_Rcca56a4c
depmod: 	i2c_probe_Rb60c5768
depmod: 	i2c_add_driver_Rcb6691c5
depmod: 	i2c_master_send_Race048b9
[root@slack:/usr/src/linux-2.4.25-pre7#] 

#v-


-- 
. JID: rmrmg(at)jabberpl(dot)org |   RMRMG   .
.           gg: #2311504         | signature .
.   mail: rmrmg(at)wp(dot)pl     |  version  .
.  registered Linux user 261525  |   0.0.3   .

[-- Attachment #2: .config.bz2 --]
[-- Type: application/octet-stream, Size: 4771 bytes --]

Re: Linux 2.4.25-pre7

[Rafał 'rmrmg' Roszak]

begin  Rafał 'rmrmg' Roszak <rmrmg@wp.pl> quote:

> begin  Marcelo Tosatti <marcelo.tosatti@cyclades.com> quote:
> 
> > Here goes -pre number 7 of 2.4.25 series.
> 
> #v+
> 
> if [ -r System.map ]; then /sbin/depmod -ae -F System.map 
> 2.4.25-pre7; fi depmod: *** Unresolved symbols in
[...]

I forgot set I2C bit-banging interfaces.
 Sorry for spam.

-- 
. JID: rmrmg(at)jabberpl(dot)org |   RMRMG   .
.           gg: #2311504         | signature .
.   mail: rmrmg(at)wp(dot)pl     |  version  .
.  registered Linux user 261525  |   0.0.3   .

Re: Linux 2.4.25-pre7

[Eyal Lebedinsky]

Marcelo Tosatti wrote:
> Here goes -pre number 7 of 2.4.25 series.

cp aty128fb.o clgenfb.o cyber2000fb.o fbcon-afb.o fbcon-cfb16.o
fbcon-cfb2.o fbc
on-cfb24.o fbcon-cfb32.o fbcon-cfb4.o fbcon-cfb8.o fbcon-hga.o
fbcon-ilbm.o fbco
n-iplan2p2.o fbcon-iplan2p4.o fbcon-iplan2p8.o fbcon-mac.o fbcon-mfb.o
fbcon-vga
-planes.o fbcon-vga.o fbgen.o hgafb.o it8181fb.o mdacon.o neofb.o
pm2fb.o pm3fb.
o radeonfb.o sstfb.o tdfxfb.o tridentfb.o vfb.o vga16fb.o
/lib/modules/2.4.25-pr
e7/kernel/drivers/video/
cp: cannot stat `it8181fb.o': No such file or directory
make[2]: *** [_modinst__] Error 1
make[2]: Leaving directory
`/data2/usr/local/src/linux-2.4-pre/drivers/video'

There are no it8181fb.* files there.

--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>

Re: Linux 2.4.25-pre7

[Yoichi Yuasa]

Hi,

On Sat, 24 Jan 2004 22:21:36 +1100
Eyal Lebedinsky <eyal@eyal.emu.id.au> wrote:

> Marcelo Tosatti wrote:
> > Here goes -pre number 7 of 2.4.25 series.
> 
> cp aty128fb.o clgenfb.o cyber2000fb.o fbcon-afb.o fbcon-cfb16.o
> fbcon-cfb2.o fbc
> on-cfb24.o fbcon-cfb32.o fbcon-cfb4.o fbcon-cfb8.o fbcon-hga.o
> fbcon-ilbm.o fbco
> n-iplan2p2.o fbcon-iplan2p4.o fbcon-iplan2p8.o fbcon-mac.o fbcon-mfb.o
> fbcon-vga
> -planes.o fbcon-vga.o fbgen.o hgafb.o it8181fb.o mdacon.o neofb.o
> pm2fb.o pm3fb.
> o radeonfb.o sstfb.o tdfxfb.o tridentfb.o vfb.o vga16fb.o
> /lib/modules/2.4.25-pr
> e7/kernel/drivers/video/
> cp: cannot stat `it8181fb.o': No such file or directory
> make[2]: *** [_modinst__] Error 1
> make[2]: Leaving directory
> `/data2/usr/local/src/linux-2.4-pre/drivers/video'
> 
> There are no it8181fb.* files there.

This file comes from a MIPS CVS tree.

I have this file.
You can get following.

http://www.hh.iij4u.or.jp/~yuasa/linux-vr/v2.4/it8181fb.c

Marcelo,
Please add this file to next pre.

Thanks,

Yoichi

Re: Linux 2.4.25-pre7

[Eyal Lebedinsky]

Yoichi Yuasa wrote:
> > `/data2/usr/local/src/linux-2.4-pre/drivers/video'
> >
> > There are no it8181fb.* files there.
> 
> This file comes from a MIPS CVS tree.
> 
> I have this file.
> You can get following.
> 
> http://www.hh.iij4u.or.jp/~yuasa/linux-vr/v2.4/it8181fb.c

Is this a MIPS only file? I run on x86 and it was selected:

   if [ "$CONFIG_PCI" = "y" -o "$CONFIG_CPU_VR41XX" = "y" ]; then
      tristate '  ITE IT8181E/F support' CONFIG_FB_IT8181
   fi 

Maybe we need a '-a' instead?

--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>

Re: Linux 2.4.25-pre7

[Yoichi Yuasa]

On Sun, 25 Jan 2004 11:28:15 +1100
Eyal Lebedinsky <eyal@eyal.emu.id.au> wrote:

> Yoichi Yuasa wrote:
> > > `/data2/usr/local/src/linux-2.4-pre/drivers/video'
> > >
> > > There are no it8181fb.* files there.
> > 
> > This file comes from a MIPS CVS tree.
> > 
> > I have this file.
> > You can get following.
> > 
> > http://www.hh.iij4u.or.jp/~yuasa/linux-vr/v2.4/it8181fb.c
> 
> Is this a MIPS only file?

No,

> I run on x86 and it was selected:
> 
>    if [ "$CONFIG_PCI" = "y" -o "$CONFIG_CPU_VR41XX" = "y" ]; then
>       tristate '  ITE IT8181E/F support' CONFIG_FB_IT8181
>    fi 
> 
> Maybe we need a '-a' instead?

If you get IT8181 card, you can use on x86 with PCI.

Yoichi

Re: Linux 2.4.25-pre7

[Eyal Lebedinsky]

Yoichi Yuasa wrote:
> >
> > There are no it8181fb.* files there.
> 
> This file comes from a MIPS CVS tree.
> 
> I have this file.
> You can get following.
> 
> http://www.hh.iij4u.or.jp/~yuasa/linux-vr/v2.4/it8181fb.c

I added it and now get:

gcc -D__KERNEL__ -I/data2/usr/local/src/linux-2.4-pre/include -Wall
-Wstrict-pro
totypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer
 -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4
-DMODULE -DM
ODVERSIONS -include
/data2/usr/local/src/linux-2.4-pre/include/linux/modversions
.h  -nostdinc -iwithprefix include -DKBUILD_BASENAME=it8181fb  -c -o
it8181fb.o 
it8181fb.c
it8181fb.c: In function `it8181fb_init':
it8181fb.c:1200: `PCI_DEVICE_ID_ITE_IT8181' undeclared (first use in
this functi
on)
it8181fb.c:1200: (Each undeclared identifier is reported only once
it8181fb.c:1200: for each function it appears in.)
it8181fb.c: At top level:
it8181fb.c:162: warning: `fontname' defined but not used
make[2]: *** [it8181fb.o] Error 1
make[2]: Leaving directory
`/data2/usr/local/src/linux-2.4-pre/drivers/video'

So maybe it really is a MIPS only file (I am on x86)?

--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>

Re: Linux 2.4.25-pre7

[Yoichi Yuasa]

On Sun, 25 Jan 2004 11:51:30 +1100
Eyal Lebedinsky <eyal@eyal.emu.id.au> wrote:

> Yoichi Yuasa wrote:
> > >
> > > There are no it8181fb.* files there.
> > 
> > This file comes from a MIPS CVS tree.
> > 
> > I have this file.
> > You can get following.
> > 
> > http://www.hh.iij4u.or.jp/~yuasa/linux-vr/v2.4/it8181fb.c
> 
> I added it and now get:
> 
> gcc -D__KERNEL__ -I/data2/usr/local/src/linux-2.4-pre/include -Wall
> -Wstrict-pro
> totypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
> -fomit-frame-pointer
>  -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4
> -DMODULE -DM
> ODVERSIONS -include
> /data2/usr/local/src/linux-2.4-pre/include/linux/modversions
> .h  -nostdinc -iwithprefix include -DKBUILD_BASENAME=it8181fb  -c -o
> it8181fb.o 
> it8181fb.c
> it8181fb.c: In function `it8181fb_init':
> it8181fb.c:1200: `PCI_DEVICE_ID_ITE_IT8181' undeclared (first use in
> this functi
> on)
> it8181fb.c:1200: (Each undeclared identifier is reported only once
> it8181fb.c:1200: for each function it appears in.)
> it8181fb.c: At top level:
> it8181fb.c:162: warning: `fontname' defined but not used
> make[2]: *** [it8181fb.o] Error 1
> make[2]: Leaving directory
> `/data2/usr/local/src/linux-2.4-pre/drivers/video'
> 
> So maybe it really is a MIPS only file (I am on x86)?

I don't know why.
When the patch was sent, the addition to a header was not sent, either.

You can see all about it8181fb's patch.

http://www.hh.iij4u.or.jp/~yuasa/linux-vr/v2.4/it8181fb-v24.diff

Yoichi

Re: Linux 2.4.25-pre7 - no DRQ after issuing WRITE

[Gabor Z. Papp]

* Marcelo Tosatti <marcelo.tosatti@cyclades.com>:

| Please help testing! :)

Here we go: http://gzp.odpn.net/tmp/linux-2.4.25-pre7/

The "no DRQ after issuing WRITE" problem with 2 120GB Seagate
harddisk. I don't think its hw problem, because these disks are fine
in other environment. More "load" related, without running them in sw
raid mode, the problem doesn't hit me so quickly.

Re: Linux 2.4.25-pre7 - no DRQ after issuing WRITE

[Marcelo Tosatti]

On Sun, 25 Jan 2004, Gabor Z. Papp wrote:

> * Marcelo Tosatti <marcelo.tosatti@cyclades.com>:
>
> | Please help testing! :)
>
> Here we go: http://gzp.odpn.net/tmp/linux-2.4.25-pre7/
>
> The "no DRQ after issuing WRITE" problem with 2 120GB Seagate
> harddisk. I don't think its hw problem, because these disks are fine
> in other environment. More "load" related, without running them in sw
> raid mode, the problem doesn't hit me so quickly.

Hi Gabor,

I'm not IDE expert, but these errors look like hardware fault for me
(Bartlomiej CCed).

What about 2.6 and older 2.4 kernels on the same hardware ?

-------------
Mounted devfs on /dev
Freeing unused kernel memory: 116k freed
hde: dma_timer_expiry: dma status == 0x21
hdg: dma_timer_expiry: dma status == 0x21
hde: error waiting for DMA
hde: dma timeout retry: status=0x7f { DriveReady DeviceFault SeekComplete
DataRequest CorrectedError Index Error }
hde: dma timeout retry: error=0x7f { DriveStatusError UncorrectableError
SectorIdNotFound TrackZeroNotFound AddrMarkNotFound },
LBAsect=9343692930943, high=556927, low=8355711, sector=4352
hde: DMA disabled
hdg: error waiting for DMA
hdg: dma timeout retry: status=0x58 { DriveReady SeekComplete DataRequest
}
hdg: status error: status=0x50 { DriveReady SeekComplete }
hdg: no DRQ after issuing MULTWRITE
hdg: status timeout: status=0xd0 { Busy }

>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: Linux 2.4.25-pre7 - no DRQ after issuing WRITE

[Gabor Z. Papp]

* Marcelo Tosatti <marcelo.tosatti@cyclades.com>:

| > Here we go: http://gzp.odpn.net/tmp/linux-2.4.25-pre7/
| >
| > The "no DRQ after issuing WRITE" problem with 2 120GB Seagate

...

| I'm not IDE expert, but these errors look like hardware fault for me
| (Bartlomiej CCed).
| 
| What about 2.6 and older 2.4 kernels on the same hardware ?

Same kernel works fine in a non-sw-raid environment, when I can't
stress enough the harddisks to fail. When I boot NetBSD 1.6.1, I'm
able to read-write the disks nonstop without any error. Thats why I
think its not hw problem, but I would like to use Linux 2.4, so I'm
waiting for Bartlomiej.

| -------------
| Mounted devfs on /dev
| Freeing unused kernel memory: 116k freed
| hde: dma_timer_expiry: dma status == 0x21
| hdg: dma_timer_expiry: dma status == 0x21
| hde: error waiting for DMA
| hde: dma timeout retry: status=0x7f { DriveReady DeviceFault SeekComplete
| DataRequest CorrectedError Index Error }
| hde: dma timeout retry: error=0x7f { DriveStatusError UncorrectableError
| SectorIdNotFound TrackZeroNotFound AddrMarkNotFound },
| LBAsect=9343692930943, high=556927, low=8355711, sector=4352
| hde: DMA disabled
| hdg: error waiting for DMA
| hdg: dma timeout retry: status=0x58 { DriveReady SeekComplete DataRequest
| }
| hdg: status error: status=0x50 { DriveReady SeekComplete }
| hdg: no DRQ after issuing MULTWRITE
| hdg: status timeout: status=0xd0 { Busy }

Re: Linux 2.4.25-pre7 - no DRQ after issuing WRITE

[Gabor Z. Papp]

* "Gabor Z. Papp" <gzp@papp.hu>:

| | I'm not IDE expert, but these errors look like hardware fault for me
| | (Bartlomiej CCed).

Replaced the really bad disk with a good one, and the DRQ problem
still exist. What to do?

http://gzp.odpn.net/tmp/linux-2.4.25-pre7-nr3/

Re: Linux 2.4.25-pre7

[Rusty Russell]

On Fri, 23 Jan 2004 16:58:24 -0200 (BRST)
Marcelo Tosatti <marcelo.tosatti@cyclades.com> wrote:
> Here goes -pre number 7 of 2.4.25 series.

Any chance of the forward-compatible module_param patch?

Name: 2.4 module_param Forward Compatibility Macros
Author: Rusty Russell
Status: Tested on 2.5.24-pre6
Version: 2.4

D: Simple uses of module_param() (implemented in 2.6) can be mapped
D: onto the old MODULE_PARM macros.
D: 
D: New code should use module_param() because:
D: 1) Types are checked,
D: 2) Existence of parameters are checked,
D: 3) Customized types are possible [1]
D: 4) Customized set/get routines are possible [1]
D: 5) Parameters appear as boot params with prefix "<modname>." [1]
D: 6) Optional viewing and control through sysfs [2]
D: 
D: [1] Not for 2.4 compatibility macros
D: [2] Not in 2.6.1 or 2.4, and only if third arg non-zero.

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .25425-linux-2.4.25-pre6/include/linux/moduleparam.h .25425-linux-2.4.25-pre6.updated/include/linux/moduleparam.h
--- .25425-linux-2.4.25-pre6/include/linux/moduleparam.h	1970-01-01 10:00:00.000000000 +1000
+++ .25425-linux-2.4.25-pre6.updated/include/linux/moduleparam.h	2004-01-21 14:24:41.000000000 +1100
@@ -0,0 +1,25 @@
+#ifndef _LINUX_MODULE_PARAMS_H
+#define _LINUX_MODULE_PARAMS_H
+/* Macros for (very simple) module parameter compatibility with 2.6. */
+#include <linux/module.h>
+
+/* type is byte, short, ushort, int, uint, long, ulong, bool. (2.6
+   has more, but they are not supported).  perm is permissions when
+   it appears in sysfs: 0 means doens't appear, 0444 means read-only
+   by everyone, 0644 means changable dynamically by root, etc.  name
+   must be in scope (unlike MODULE_PARM).
+*/
+#define module_param(name, type, perm)					     \
+	static inline void *__check_existence_##name(void) { return &name; } \
+	MODULE_PARM(name, _MODULE_PARM_STRING_ ## type)
+
+#define _MODULE_PARM_STRING_byte "b"
+#define _MODULE_PARM_STRING_short "h"
+#define _MODULE_PARM_STRING_ushort "h"
+#define _MODULE_PARM_STRING_int "i"
+#define _MODULE_PARM_STRING_uint "i"
+#define _MODULE_PARM_STRING_long "l"
+#define _MODULE_PARM_STRING_ulong "l"
+#define _MODULE_PARM_STRING_bool "i"
+
+#endif /* _LINUX_MODULE_PARAM_TYPES_H */


-- 
   there are those who do and those who hang on and you don't see too
   many doers quoting their contemporaries.  -- Larry McVoy

Re: Linux 2.4.25-pre7

[Marcelo Tosatti]

On Mon, 26 Jan 2004, Rusty Russell wrote:

> On Fri, 23 Jan 2004 16:58:24 -0200 (BRST)
> Marcelo Tosatti <marcelo.tosatti@cyclades.com> wrote:
> > Here goes -pre number 7 of 2.4.25 series.
>
> Any chance of the forward-compatible module_param patch?
>
> Name: 2.4 module_param Forward Compatibility Macros
> Author: Rusty Russell
> Status: Tested on 2.5.24-pre6
> Version: 2.4
>
> D: Simple uses of module_param() (implemented in 2.6) can be mapped
> D: onto the old MODULE_PARM macros.
> D:
> D: New code should use module_param() because:
> D: 1) Types are checked,
> D: 2) Existence of parameters are checked,
> D: 3) Customized types are possible [1]
> D: 4) Customized set/get routines are possible [1]
> D: 5) Parameters appear as boot params with prefix "<modname>." [1]
> D: 6) Optional viewing and control through sysfs [2]
> D:
> D: [1] Not for 2.4 compatibility macros
> D: [2] Not in 2.6.1 or 2.4, and only if third arg non-zero.
>
> diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .25425-linux-2.4.25-pre6/include/linux/moduleparam.h .25425-linux-2.4.25-pre6.updated/include/linux/moduleparam.h
> --- .25425-linux-2.4.25-pre6/include/linux/moduleparam.h	1970-01-01 10:00:00.000000000 +1000
> +++ .25425-linux-2.4.25-pre6.updated/include/linux/moduleparam.h	2004-01-21 14:24:41.000000000 +1100
> @@ -0,0 +1,25 @@
> +#ifndef _LINUX_MODULE_PARAMS_H
> +#define _LINUX_MODULE_PARAMS_H
> +/* Macros for (very simple) module parameter compatibility with 2.6. */
> +#include <linux/module.h>
> +
> +/* type is byte, short, ushort, int, uint, long, ulong, bool. (2.6
> +   has more, but they are not supported).  perm is permissions when
> +   it appears in sysfs: 0 means doens't appear, 0444 means read-only
> +   by everyone, 0644 means changable dynamically by root, etc.  name
> +   must be in scope (unlike MODULE_PARM).
> +*/
> +#define module_param(name, type, perm)					     \
> +	static inline void *__check_existence_##name(void) { return &name; } \
> +	MODULE_PARM(name, _MODULE_PARM_STRING_ ## type)
> +
> +#define _MODULE_PARM_STRING_byte "b"
> +#define _MODULE_PARM_STRING_short "h"
> +#define _MODULE_PARM_STRING_ushort "h"
> +#define _MODULE_PARM_STRING_int "i"
> +#define _MODULE_PARM_STRING_uint "i"
> +#define _MODULE_PARM_STRING_long "l"
> +#define _MODULE_PARM_STRING_ulong "l"
> +#define _MODULE_PARM_STRING_bool "i"
> +
> +#endif /* _LINUX_MODULE_PARAM_TYPES_H */

Hi Rusty,

I think it is suitable. Will apply.

Thank you.

Re: Linux 2.4.25-pre7 - no DRQ after issuing WRITE

[Bartlomiej Zolnierkiewicz]

On Wednesday 04 of February 2004 16:29, Gabor Z. Papp wrote:
> * Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>:
> | Dunno :-).  I use smartmontools and non-Linux vendor tools
> | (ie. from www.seagate.com) to make sure that drive is okay.
> | If these tests pass and drive works with other OS-es then
> | I suspect bug in IDE core or in specific IDE chipset driver.
>
> Downloaded the seagate seatools, and ran the full tests.
>
> The diagnostic tool told me I have to send back the disk...
>
> DST - Errors - Status: 07
> Short Test Failed: [date]
>
> BAD Sector LBA: 125249531
> Unable to resolve sector usage.
>
> [lot of such errors for various sectors]
>
> Scan Completed... PROBLEMS FOUND.
>
> So, "no DRQ after issuing WRITE" is due these drive errors?

Yes, when DMA write fails (ie. because of a bad sector), driver disables
DMA and tries to retry transfer in PIO mode but obviously that fails too
(drive doesn't "ack" PIO write command and thus this message).