From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752170AbbGOMDj (ORCPT ); Wed, 15 Jul 2015 08:03:39 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:33682 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751843AbbGOMDg convert rfc822-to-8bit (ORCPT ); Wed, 15 Jul 2015 08:03:36 -0400 From: Michal Nazarewicz To: Joonsoo Kim , Andrew Morton Cc: Sasha Levin , Stefan Strogin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim Subject: Re: [PATCH 2/2] mm/cma_debug: correct size input to bitmap function In-Reply-To: <1436942129-18020-2-git-send-email-iamjoonsoo.kim@lge.com> Organization: http://mina86.com/ References: <1436942129-18020-1-git-send-email-iamjoonsoo.kim@lge.com> <1436942129-18020-2-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.0.50.1 (x86_64-unknown-linux-gnu) X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd;KFrfMCylc}gc??'U2j,!8%xdD Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:150715:iamjoonsoo.kim@lge.com::Oc8DmUn+4ABrr5LZ:0000000000000000000000000000000000000000LDJ X-Hashcash: 1:20:150715:akpm@linux-foundation.org::xxd4RiD8ifKcc0w2:00000000000000000000000000000000000013+e X-Hashcash: 1:20:150715:sasha.levin@oracle.com::wgfOYkts6pqmrPlG:00000000000000000000000000000000000000015UM X-Hashcash: 1:20:150715:stefan.strogin@gmail.com::ko2+JrNFhAo3lYat:00000000000000000000000000000000000001sXh X-Hashcash: 1:20:150715:linux-kernel@vger.kernel.org::Chq/91zW31Nu9lCI:0000000000000000000000000000000003EhO X-Hashcash: 1:20:150715:js1304@gmail.com::JgM/tyxnjU2xMjMA:045z6 X-Hashcash: 1:20:150715:linux-mm@kvack.org::DT4xViJqLtlm1joi:0000000000000000000000000000000000000000000Fms2 Date: Wed, 15 Jul 2015 14:03:32 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 15 2015, Joonsoo Kim wrote: > In CMA, 1 bit in bitmap means 1 << order_per_bits pages so > size of bitmap is cma->count >> order_per_bits rather than > just cma->count. This patch fixes it. > > Signed-off-by: Joonsoo Kim Acked-by: Michal Nazarewicz > --- > mm/cma_debug.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/cma_debug.c b/mm/cma_debug.c > index 22190a7..f8e4b60 100644 > --- a/mm/cma_debug.c > +++ b/mm/cma_debug.c > @@ -39,7 +39,7 @@ static int cma_used_get(void *data, u64 *val) > > mutex_lock(&cma->lock); > /* pages counter is smaller than sizeof(int) */ > - used = bitmap_weight(cma->bitmap, (int)cma->count); > + used = bitmap_weight(cma->bitmap, (int)cma_bitmap_maxno(cma)); > mutex_unlock(&cma->lock); > *val = (u64)used << cma->order_per_bit; > > @@ -52,13 +52,14 @@ static int cma_maxchunk_get(void *data, u64 *val) > struct cma *cma = data; > unsigned long maxchunk = 0; > unsigned long start, end = 0; > + unsigned long bitmap_maxno = cma_bitmap_maxno(cma); > > mutex_lock(&cma->lock); > for (;;) { > - start = find_next_zero_bit(cma->bitmap, cma->count, end); > + start = find_next_zero_bit(cma->bitmap, bitmap_maxno, end); > if (start >= cma->count) > break; > - end = find_next_bit(cma->bitmap, cma->count, start); > + end = find_next_bit(cma->bitmap, bitmap_maxno, start); > maxchunk = max(end - start, maxchunk); > } > mutex_unlock(&cma->lock); > -- > 1.9.1 > -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------ooO--(_)--Ooo--