From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932566AbcGHOEq (ORCPT ); Fri, 8 Jul 2016 10:04:46 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:38755 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755108AbcGHOEh convert rfc822-to-8bit (ORCPT ); Fri, 8 Jul 2016 10:04:37 -0400 From: Michal Nazarewicz To: Felipe Balbi , Baolin Wang Cc: gregkh@linuxfoundation.org, eu@felipetonello.com, r.baldyga@samsung.com, dan.carpenter@oracle.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, broonie@kernel.org, baolin.wang@linaro.org Subject: Re: [PATCH] usb: gadget: f_midi: Add checking if it need align buffer's size to an ep's maxpacketsize In-Reply-To: <87lh1ci7tt.fsf@linux.intel.com> Organization: http://mina86.com/ References: <8ff4f814afc70cf9c00cc6718d7ae93fae94884a.1467881565.git.baolin.wang@linaro.org> <87lh1ci7tt.fsf@linux.intel.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:160708:eu@felipetonello.com::W9xIWTQfmnat87lO:000000000000000000000000000000000000000000CC1 X-Hashcash: 1:20:160708:baolin.wang@linaro.org::g8avJLqe3zwOym8F:0000000000000000000000000000000000000000CJ3 X-Hashcash: 1:20:160708:dan.carpenter@oracle.com::WuY6oLuL8y0TBm1L:00000000000000000000000000000000000000/uA X-Hashcash: 1:20:160708:balbi@kernel.org::fNBJcr2KBZSCMJHI:01oe3 X-Hashcash: 1:20:160708:r.baldyga@samsung.com::gs2cM1TuVWgP6Cw2:00000000000000000000000000000000000000001Ycu X-Hashcash: 1:20:160708:broonie@kernel.org::ct7MjmTFPiMJKMEV:00000000000000000000000000000000000000000001s+z X-Hashcash: 1:20:160708:baolin.wang@linaro.org::Jp2CkwcjswoQpUGi:0000000000000000000000000000000000000003Vg8 X-Hashcash: 1:20:160708:gregkh@linuxfoundation.org::orOM1MZAFXo7v4A4:000000000000000000000000000000000004O0e X-Hashcash: 1:20:160708:linux-usb@vger.kernel.org::yzMpl4ciOBYcnKxb:0000000000000000000000000000000000006g/Y X-Hashcash: 1:20:160708:linux-kernel@vger.kernel.org::RoU2Yiok9P6s3diM:0000000000000000000000000000000008KxC Date: Fri, 08 Jul 2016 16:04:31 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Baolin Wang writes: >> @@ -359,10 +361,12 @@ static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt) >> >> /* allocate a bunch of read buffers and queue them all at once. */ >> for (i = 0; i < midi->qlen && err == 0; i++) { >> - struct usb_request *req = >> - midi_alloc_ep_req(midi->out_ep, >> - max_t(unsigned, midi->buflen, >> - bulk_out_desc.wMaxPacketSize)); >> + struct usb_request *req; >> + >> + length = usb_ep_align_maybe(midi->gadget, midi->out_ep, >> + midi->buflen); On Fri, Jul 08 2016, Felipe Balbi wrote: > after calling usb_ep_align_maybe()... > >> + req = midi_alloc_ep_req(midi->out_ep, >> + max_t(unsigned, length, bulk_out_desc.wMaxPacketSize)); > > ... max_t() is pointless. length will *always* >= wMaxPacketSize. That is only true for gadgets with the quirk. usb_ep_align_maybe is a noöp for gadgets without the quirk. -- Best regards ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»