From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752081AbbGOMD1 (ORCPT ); Wed, 15 Jul 2015 08:03:27 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:36859 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751843AbbGOMDZ convert rfc822-to-8bit (ORCPT ); Wed, 15 Jul 2015 08:03:25 -0400 From: Michal Nazarewicz To: Joonsoo Kim , Andrew Morton Cc: Sasha Levin , Stefan Strogin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim Subject: Re: [PATCH 1/2] mm/cma_debug: fix debugging alloc/free interface In-Reply-To: <1436942129-18020-1-git-send-email-iamjoonsoo.kim@lge.com> Organization: http://mina86.com/ References: <1436942129-18020-1-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.0.50.1 (x86_64-unknown-linux-gnu) X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd;KFrfMCylc}gc??'U2j,!8%xdD Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:150715:akpm@linux-foundation.org::6ZP/sc2voGx5nzz/:00000000000000000000000000000000000017dH X-Hashcash: 1:20:150715:linux-kernel@vger.kernel.org::HIHkM6aBCR2hphME:0000000000000000000000000000000002ieT X-Hashcash: 1:20:150715:linux-mm@kvack.org::wGVEYGu/SjvcVJY9:000000000000000000000000000000000000000000023E7 X-Hashcash: 1:20:150715:stefan.strogin@gmail.com::BYzff4HA6Ex3Z13C:000000000000000000000000000000000000029Hp X-Hashcash: 1:20:150715:iamjoonsoo.kim@lge.com::NAthINA6c+m7zHol:0000000000000000000000000000000000000002eFy X-Hashcash: 1:20:150715:js1304@gmail.com::eVoGNPVZVzvWQFhP:07fJk X-Hashcash: 1:20:150715:sasha.levin@oracle.com::lONKDq3EM2YlYiWm:0000000000000000000000000000000000000007wkw Date: Wed, 15 Jul 2015 14:03:20 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 15 2015, Joonsoo Kim wrote: > CMA has alloc/free interface for debugging. It is intended that alloc/free > occurs in specific CMA region, but, currently, alloc/free interface is > on root dir due to the bug so we can't select CMA region where alloc/free > happens. > > This patch fixes this problem by making alloc/free interface per > CMA region. > > Signed-off-by: Joonsoo Kim Acked-by: Michal Nazarewicz > --- > mm/cma_debug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/cma_debug.c b/mm/cma_debug.c > index 7621ee3..22190a7 100644 > --- a/mm/cma_debug.c > +++ b/mm/cma_debug.c > @@ -170,10 +170,10 @@ static void cma_debugfs_add_one(struct cma *cma, int idx) > > tmp = debugfs_create_dir(name, cma_debugfs_root); > > - debugfs_create_file("alloc", S_IWUSR, cma_debugfs_root, cma, > + debugfs_create_file("alloc", S_IWUSR, tmp, cma, > &cma_alloc_fops); > > - debugfs_create_file("free", S_IWUSR, cma_debugfs_root, cma, > + debugfs_create_file("free", S_IWUSR, tmp, cma, > &cma_free_fops); > > debugfs_create_file("base_pfn", S_IRUGO, tmp, > -- > 1.9.1 > -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------ooO--(_)--Ooo--