From: Michal Nazarewicz <mina86@mina86.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
balbi@kernel.org, gregkh@linuxfoundation.org,
bhelgaas@google.com, heikki.krogerus@linux.intel.com
Cc: linux-geode@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype
Date: Mon, 13 Feb 2017 17:07:20 +0100 [thread overview]
Message-ID: <xa1ta89qdqh3.fsf@mina86.com> (raw)
In-Reply-To: <6acc14afdbfef03164e38e60d956add654756d91.1486867169.git.garsilva@embeddedor.com>
On Mon, Feb 13 2017, Gustavo A. R. Silva wrote:
> Remove unnecessary variable and update function prototype.
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> drivers/usb/gadget/udc/amd5536udc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/amd5536udc.c b/drivers/usb/gadget/udc/amd5536udc.c
> index ded97a3..3f64a06 100644
> --- a/drivers/usb/gadget/udc/amd5536udc.c
> +++ b/drivers/usb/gadget/udc/amd5536udc.c
> @@ -608,9 +608,8 @@ udc_alloc_request(struct usb_ep *usbep, gfp_t gfp)
> }
>
> /* frees pci pool descriptors of a DMA chain */
> -static int udc_free_dma_chain(struct udc *dev, struct udc_request *req)
> +static void udc_free_dma_chain(struct udc *dev, struct udc_request *req)
> {
> - int ret_val = 0;
> struct udc_data_dma *td = req->td_data;
> unsigned int i;
>
> @@ -629,8 +628,6 @@ static int udc_free_dma_chain(struct udc *dev, struct udc_request *req)
> td = NULL;
> addr = addr_aux;
> }
> -
> - return ret_val;
> }
>
> /* Frees request packet, called by gadget driver */
> --
> 2.5.0
>
--
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»
prev parent reply other threads:[~2017-02-13 16:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 15:37 [PATCH 0/2] avoid use of freed pointer Gustavo A. R. Silva
2017-02-13 15:40 ` [PATCH 1/2] usb: gadget: udc: " Gustavo A. R. Silva
2017-02-13 16:06 ` Michal Nazarewicz
2017-02-14 21:53 ` Gustavo A. R. Silva
2017-02-14 21:58 ` [PATCH v2 " Gustavo A. R. Silva
2017-02-14 22:03 ` [PATCH v2 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype Gustavo A. R. Silva
2017-04-04 4:28 ` [PATCH v2 1/2] usb: gadget: udc: avoid use of freed pointer Gustavo A. R. Silva
2017-04-04 4:34 ` [PATCH v2 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype Gustavo A. R. Silva
2017-04-05 12:32 ` [PATCH v2 1/2] usb: gadget: udc: avoid use of freed pointer Felipe Balbi
2017-02-13 15:40 ` [PATCH 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype Gustavo A. R. Silva
2017-02-13 16:07 ` Michal Nazarewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa1ta89qdqh3.fsf@mina86.com \
--to=mina86@mina86.com \
--cc=balbi@kernel.org \
--cc=bhelgaas@google.com \
--cc=garsilva@embeddedor.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox