From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758205AbcG0Thu (ORCPT ); Wed, 27 Jul 2016 15:37:50 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:34984 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754303AbcG0Thr convert rfc822-to-8bit (ORCPT ); Wed, 27 Jul 2016 15:37:47 -0400 From: Michal Nazarewicz To: "Felipe F. Tonello" , linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Felipe Balbi , Baolin Wang , Andrzej Pietrasiewicz Subject: Re: [PATCH 1/9] usb: gadget: fix usb_ep_align_maybe endianness and new usb_ep_align In-Reply-To: <20160726191200.18943-2-eu@felipetonello.com> Organization: http://mina86.com/ References: <20160726191200.18943-1-eu@felipetonello.com> <20160726191200.18943-2-eu@felipetonello.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:160727:andrzej.p@samsung.com::tAzQlZ5WTNsK31O7:00000000000000000000000000000000000000000NMr X-Hashcash: 1:20:160727:balbi@kernel.org::8YtbZrQOinONVinJ:00KQ/ X-Hashcash: 1:20:160727:linux-usb@vger.kernel.org::IySG/nyx+RaNq6AE:0000000000000000000000000000000000001XDN X-Hashcash: 1:20:160727:linux-kernel@vger.kernel.org::GJp7YTMS4ejw7TaK:0000000000000000000000000000000005Oxu X-Hashcash: 1:20:160727:baolin.wang@linaro.org::5IJ9P4bG/+i1JX06:0000000000000000000000000000000000000005JfG X-Hashcash: 1:20:160727:eu@felipetonello.com::hZKmIzdGo6mUZG1W:000000000000000000000000000000000000000007x59 Date: Wed, 27 Jul 2016 21:37:43 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26 2016, Felipe F. Tonello wrote: > USB spec specifies wMaxPacketSize to be little endian (as other properties), > so when using this variable in the driver we should convert to the current > CPU endianness if necessary. > > This patch also introduces usb_ep_align() which does always returns the > aligned buffer size for an endpoint. This is useful to be used by USB requests > allocator functions. > > Signed-off-by: Felipe F. Tonello Acked-by: Michal Nazarewicz > --- > include/linux/usb/gadget.h | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h > index 612dbdfa388e..b8fa6901b881 100644 > --- a/include/linux/usb/gadget.h > +++ b/include/linux/usb/gadget.h > @@ -418,8 +418,20 @@ static inline struct usb_gadget *dev_to_usb_gadget(struct device *dev) > list_for_each_entry(tmp, &(gadget)->ep_list, ep_list) > > /** > + * usb_ep_align - returns @len aligned to ep's maxpacketsize. > + * @ep: the endpoint whose maxpacketsize is used to align @len > + * @len: buffer size's length to align to @ep's maxpacketsize > + * > + * This helper is used to align buffer's size to an ep's maxpacketsize. > + */ > +static inline size_t usb_ep_align(struct usb_ep *ep, size_t len) > +{ > + return round_up(len, (size_t)le16_to_cpu(ep->desc->wMaxPacketSize)); > +} > + > +/** > * usb_ep_align_maybe - returns @len aligned to ep's maxpacketsize if gadget > - * requires quirk_ep_out_aligned_size, otherwise reguens len. > + * requires quirk_ep_out_aligned_size, otherwise returns len. > * @g: controller to check for quirk > * @ep: the endpoint whose maxpacketsize is used to align @len > * @len: buffer size's length to align to @ep's maxpacketsize > @@ -430,8 +442,7 @@ static inline struct usb_gadget *dev_to_usb_gadget(struct device *dev) > static inline size_t > usb_ep_align_maybe(struct usb_gadget *g, struct usb_ep *ep, size_t len) > { > - return !g->quirk_ep_out_aligned_size ? len : > - round_up(len, (size_t)ep->desc->wMaxPacketSize); > + return !g->quirk_ep_out_aligned_size ? len : usb_ep_align(ep, len); I’d drop the negation: + return g->quirk_ep_out_aligned_size ? usb_ep_align(ep, len) : len; > } > > /** > -- > 2.9.0 > -- Best regards ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»