From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755669AbcARQCh (ORCPT ); Mon, 18 Jan 2016 11:02:37 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:34581 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755547AbcARQCe convert rfc822-to-8bit (ORCPT ); Mon, 18 Jan 2016 11:02:34 -0500 From: Michal Nazarewicz To: Felipe Ferreri Tonello , Felipe Balbi , Greg Kroah-Hartman , Dan Carpenter Cc: Robert Baldyga , Andrzej Pietrasiewicz , Pawel Szewczyk , linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 1/2] usb: gadget: f_midi: use flexible array member for gmidi_in_port elements In-Reply-To: <569696CE.1000707@felipetonello.com> Organization: http://mina86.com/ References: <1452311230-21431-1-git-send-email-mina86@mina86.com> <569696CE.1000707@felipetonello.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:160118:p.szewczyk@samsung.com::47M7BT/JsksgjU0r:0000000000000000000000000000000000000000jQh X-Hashcash: 1:20:160118:r.baldyga@samsung.com::x3agdi2GGP3UL2QG:00000000000000000000000000000000000000000q9S X-Hashcash: 1:20:160118:gregkh@linuxfoundation.org::8/LcIhpuW1gdBiyr:000000000000000000000000000000000001Oqd X-Hashcash: 1:20:160118:balbi@ti.com::edSuKKK0EJ6aqVoW:000001zTB X-Hashcash: 1:20:160118:andrzej.p@samsung.com::ZfmmkK89JZn+Nbss:00000000000000000000000000000000000000001qtU X-Hashcash: 1:20:160118:dan.carpenter@oracle.com::hZNvJIlF4+vQO4Lp:00000000000000000000000000000000000002UiL X-Hashcash: 1:20:160118:eu@felipetonello.com::3rspIzTvSmr9NJYF:000000000000000000000000000000000000000005KAi X-Hashcash: 1:20:160118:linux-kernel@vger.kernel.org::7DlQtxAH8Yzmsz9a:0000000000000000000000000000000004Prt Date: Mon, 18 Jan 2016 17:02:29 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 09/01/16 03:47, Michal Nazarewicz wrote: >> @@ -55,7 +55,6 @@ static const char f_midi_longname[] = "MIDI Gadget"; >> * USB <- IN endpoint <- rawmidi >> */ >> struct gmidi_in_port { >> - struct f_midi *midi; On Wed, Jan 13 2016, Felipe Ferreri Tonello wrote: > This change is unrelated. I sent a patch removing this pointer as well. Has it been merged yet? Which branch? Could you point me to the patch? >> int active; >> uint8_t cable; >> uint8_t state; >> @@ -1115,26 +1112,16 @@ static struct usb_function *f_midi_alloc(struct usb_function_instance *fi) >> } >> >> /* allocate and initialize one new instance */ >> - midi = kzalloc(sizeof(*midi), GFP_KERNEL); >> + midi = kzalloc( >> + sizeof(*midi) + opts->in_ports * sizeof(*midi->in_ports_array), >> + GFP_KERNEL); > > Is there a garantee that the compiler will always use in_ports_array at > the end of the allocated block? Yep, see . > >> if (!midi) { >> mutex_unlock(&opts->lock); >> return ERR_PTR(-ENOMEM); >> } >> >> - for (i = 0; i < opts->in_ports; i++) { >> - struct gmidi_in_port *port = kzalloc(sizeof(*port), GFP_KERNEL); >> - >> - if (!port) { >> - status = -ENOMEM; >> - mutex_unlock(&opts->lock); >> - goto setup_fail; >> - } >> - >> - port->midi = midi; >> - port->active = 0; >> - port->cable = i; >> - midi->in_port[i] = port; >> - } >> + for (i = 0; i < opts->in_ports; i++) >> + midi->in_ports_array[i].cable = i; >> >> /* set up ALSA midi devices */ >> midi->id = kstrdup(opts->id, GFP_KERNEL); -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, ミハウ “mina86” ナザレヴイツ (o o) ooo +------ooO--(_)--Ooo--