From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969658AbdEYN7M (ORCPT ); Thu, 25 May 2017 09:59:12 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37867 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751600AbdEYN7L (ORCPT ); Thu, 25 May 2017 09:59:11 -0400 From: Michal Nazarewicz To: Ian Abbott , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Cc: Alexander Potapenko , Andrew Morton , Arnd Bergmann , Borislav Petkov , Hidehiro Kawai , Ian Abbott , Jakub Kicinski , Johannes Berg , Kees Cook , Peter Zijlstra , Rasmus Villemoes , Steven Rostedt Subject: Re: [PATCH v5 2/6] linux/bug.h: correct formatting of block comment In-Reply-To: <20170525120316.24473-3-abbotti@mev.co.uk> Organization: http://mina86.com/ References: <20170525120316.24473-1-abbotti@mev.co.uk> <20170525120316.24473-3-abbotti@mev.co.uk> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& OpenPGP: id=AC1F5F5CD41888F8CC8458582060401250751FF4; url=http://mina86.com/mina86.pub X-Hashcash: 1:20:170525:rostedt@goodmis.org::4Ae48h1LGYw6JNIp:00000000000000000000000000000000000000000014WY X-Hashcash: 1:20:170525:peterz@infradead.org::+JFP0kpxvVLe8Kf/:000000000000000000000000000000000000000001jPB X-Hashcash: 1:20:170525:johannes.berg@intel.com::8qM0+yNSrqgZF+4W:000000000000000000000000000000000000000+mR X-Hashcash: 1:20:170525:bp@suse.de::oPuZ0F28NduLYBwA:00000001uoe X-Hashcash: 1:20:170525:arnd@arndb.de::I7k6zgzs0ZYiG+Ca:0000104q X-Hashcash: 1:20:170525:akpm@linux-foundation.org::2vC5yvOCjzohA/dn:0000000000000000000000000000000000000MB4 X-Hashcash: 1:20:170525:glider@google.com::UzQkbAv15Cl+SHs8:000000000000000000000000000000000000000000000/9K X-Hashcash: 1:20:170525:abbotti@mev.co.uk::nnSqceZ9+BpK5JHa:000000000000000000000000000000000000000000002eG/ X-Hashcash: 1:20:170525:abbotti@mev.co.uk::U8zB+2El8vILKyyj:000000000000000000000000000000000000000000005yZU X-Hashcash: 1:20:170525:keescook@chromium.org::9dr7lsvOhiR/VDl4:000000000000000000000000000000000000000067SX X-Hashcash: 1:20:170525:linux-arch@vger.kernel.org::aDpGn8Kk9MMKLix1:000000000000000000000000000000000005Rdz X-Hashcash: 1:20:170525:linux-kernel@vger.kernel.org::6yWGYLYQ8PwVGgNL:0000000000000000000000000000000008HjS X-Hashcash: 1:20:170525:linux@rasmusvillemoes.dk::Xv6NOcfIuF0eh9Jf:000000000000000000000000000000000000080iC X-Hashcash: 1:20:170525:jakub.kicinski@netronome.com::qF9IX7OewuknXOM7:00000000000000000000000000000000074iF X-Hashcash: 1:20:170525:hidehiro.kawai.ez@hitachi.com::YOQwdK/re1vaDhMb:000000000000000000000000000000008p7a Date: Thu, 25 May 2017 15:58:58 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4PDxWZp013297 On Thu, May 25 2017, Ian Abbott wrote: > Correct these checkpatch.pl warnings: > > |WARNING: Block comments use * on subsequent lines > |#34: FILE: include/linux/bug.h:34: > |+/* Force a compilation error if condition is true, but also produce a > |+ result (of value 0 and type size_t), so the expression can be used > > |WARNING: Block comments use a trailing */ on a separate line > |#36: FILE: include/linux/bug.h:36: > |+ aren't permitted). */ > > Signed-off-by: Ian Abbott > Cc: Andrew Morton > Cc: Kees Cook > Cc: Steven Rostedt > Cc: Peter Zijlstra > Cc: Jakub Kicinski > Cc: Rasmus Villemoes Acked-by: Michal Nazarewicz > --- > v5: Actually, there was no v1 thru v4. I called this v5 to match the > series. > --- > include/linux/bug.h | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/include/linux/bug.h b/include/linux/bug.h > index 687b557fc5eb..ca24007e2dc3 100644 > --- a/include/linux/bug.h > +++ b/include/linux/bug.h > @@ -30,10 +30,12 @@ struct pt_regs; > #define BUILD_BUG_ON_NOT_POWER_OF_2(n) \ > BUILD_BUG_ON((n) == 0 || (((n) & ((n) - 1)) != 0)) > > -/* Force a compilation error if condition is true, but also produce a > - result (of value 0 and type size_t), so the expression can be used > - e.g. in a structure initializer (or where-ever else comma expressions > - aren't permitted). */ > +/* > + * Force a compilation error if condition is true, but also produce a > + * result (of value 0 and type size_t), so the expression can be used > + * e.g. in a structure initializer (or where-ever else comma expressions > + * aren't permitted). > + */ > #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); })) > #define BUILD_BUG_ON_NULL(e) ((void *)sizeof(struct { int:-!!(e); })) -- Best regards ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»