From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751148AbdEaK5j (ORCPT ); Wed, 31 May 2017 06:57:39 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:37743 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbdEaK5g (ORCPT ); Wed, 31 May 2017 06:57:36 -0400 From: Michal Nazarewicz To: Jia-Ju Bai , balbi@kernel.org, gregkh@linuxfoundation.org, plr.vincent@gmail.com, felixhaedicke@web.de, jilin@nvidia.com, dan.carpenter@oracle.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: Re: [PATCH] gadget: Fix a sleep-in-atomic bug In-Reply-To: <1496200423-3251-1-git-send-email-baijiaju1990@163.com> Organization: http://mina86.com/ References: <1496200423-3251-1-git-send-email-baijiaju1990@163.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& OpenPGP: id=AC1F5F5CD41888F8CC8458582060401250751FF4; url=http://mina86.com/mina86.pub X-Hashcash: 1:20:170531:baijiaju1990@163.com::ibhLFFL7OFcx4V9m:000000000000000000000000000000000000000003EWc X-Hashcash: 1:20:170531:linux-kernel@vger.kernel.org::uylqlXkAylgFbYS+:0000000000000000000000000000000000W72 X-Hashcash: 1:20:170531:felixhaedicke@web.de::yjX93tYQZHZJicJ+:000000000000000000000000000000000000000000B1b X-Hashcash: 1:20:170531:plr.vincent@gmail.com::9c29XCRw6Lpioblc:00000000000000000000000000000000000000004D3J X-Hashcash: 1:20:170531:gregkh@linuxfoundation.org::lXCoTjcj3X4fQGrO:000000000000000000000000000000000001igU X-Hashcash: 1:20:170531:baijiaju1990@163.com::Q8+uz615PiS3RZWy:000000000000000000000000000000000000000001+D+ X-Hashcash: 1:20:170531:balbi@kernel.org::BSzafyHBE8kbf97h:05a0Q X-Hashcash: 1:20:170531:jilin@nvidia.com::XB4L8Mo4WbK9mSC2:07HQo X-Hashcash: 1:20:170531:linux-usb@vger.kernel.org::iY00H0Lc0DgYObJh:0000000000000000000000000000000000009Dy9 X-Hashcash: 1:20:170531:dan.carpenter@oracle.com::loywyV41NNS0uLCh:0000000000000000000000000000000000000J+s9 Date: Wed, 31 May 2017 12:57:33 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4VAvgK9030316 On Wed, May 31 2017, Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > ffs_epfile_io (acquire the lock by spin_lock_irq) > usb_ep_alloc_request(GFP_KERNEL) --> may sleep > > To fix it, the "GFP_KERNEL" is replaced with "GFP_ATOMIC". > > Signed-off-by: Jia-Ju Bai Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/function/f_fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > index 47dda34..be90e25 100644 > --- a/drivers/usb/gadget/function/f_fs.c > +++ b/drivers/usb/gadget/function/f_fs.c > @@ -1015,7 +1015,7 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data) > else > ret = ep->status; > goto error_mutex; > - } else if (!(req = usb_ep_alloc_request(ep->ep, GFP_KERNEL))) { > + } else if (!(req = usb_ep_alloc_request(ep->ep, GFP_ATOMIC))) { > ret = -ENOMEM; > } else { > req->buf = data; -- Best regards ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»