From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752150AbcJCUIb (ORCPT ); Mon, 3 Oct 2016 16:08:31 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:38479 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753495AbcJCUHf (ORCPT ); Mon, 3 Oct 2016 16:07:35 -0400 From: Michal Nazarewicz To: John Stultz Cc: Chen Yu , Felipe Balbi , Greg KH , Biggo Wang , lkml , linux-usb@vger.kernel.org, Amit Pundir , Guodong Xu Subject: Re: BUG: scheduling while atomic in f_fs when gadget remove driver In-Reply-To: Organization: http://mina86.com/ References: <205cfce1-d54c-262d-f939-ad9f37b0c52c@huawei.com> <878tud4q6x.fsf@linux.intel.com> <261ada71-8a5d-6e89-7fac-6b6ba88218d7@huawei.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.2 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:161003:gregkh@linuxfoundation.org::+SdArAsbcR4DOMYa:0000000000000000000000000000000000003wZ X-Hashcash: 1:20:161003:linux-usb@vger.kernel.org::fs31EAmeDkBTlf3i:0000000000000000000000000000000000001lom X-Hashcash: 1:20:161003:amit.pundir@linaro.org::EAgM/SEaIBHJ/uM7:0000000000000000000000000000000000000001P3p X-Hashcash: 1:20:161003:guodong.xu@linaro.org::EfTO1MIQSfVJjJcx:000000000000000000000000000000000000000015N1 X-Hashcash: 1:20:161003:chenyu56@huawei.com::zr+y7whctEULRkgk:00000000000000000000000000000000000000000023hM X-Hashcash: 1:20:161003:john.stultz@linaro.org::hMmksnYx0ipZJA+U:0000000000000000000000000000000000000004lrj X-Hashcash: 1:20:161003:wangbinghui@hisilicon.com::ZId5nPSFXH5E5XrA:00000000000000000000000000000000000081Zi X-Hashcash: 1:20:161003:linux-kernel@vger.kernel.org::+RYFq93Zu7poywpA:0000000000000000000000000000000009sr0 X-Hashcash: 1:20:161003:felipe.balbi@linux.intel.com::+VxnZiX6WANeOtKk:000000000000000000000000000000000ECb/ Date: Mon, 03 Oct 2016 22:07:32 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u93K8Y5c004061 On Mon, Oct 03 2016, John Stultz wrote: > On Wed, Sep 28, 2016 at 2:38 PM, Michal Nazarewicz wrote: >> On Wed, Sep 28 2016, Michal Nazarewicz wrote: >>> With that done, the only thing which needs a mutex is >>> epfile->read_buffer. >> >> Perhaps this would do: >> >> ---- >8 -------------------------------------------------- ------------- >> From 6416a1065203a39328311f6c58083089efe169aa Mon Sep 17 00:00:00 2001 >> From: Michal Nazarewicz >> Date: Wed, 28 Sep 2016 23:36:56 +0200 >> Subject: [RFC] usb: gadget: f_fs: stop sleeping in ffs_func_eps_disable >> MIME-Version: 1.0 >> Content-Type: text/plain; charset=UTF-8 >> Content-Transfer-Encoding: 8bit >> >> ffs_func_eps_disable is called from atomic context so it cannot sleep >> thus cannot grab a mutex. Change the handling of epfile->read_buffer >> to use non-sleeping synchronisation method. >> >> Reported-by: Chen Yu >> Signed-off-by: Michał Nazarewicz >> Fixes: 9353afbbfa7b ("buffer data from ‘oversized’ OUT requests") > > So the patch here seems to be in some odd encoding? O_o It’s UTF-8. > Can you resend it using git-send-email or in some way other then > embedding it inline here? Maybe just point me to a git tree that has > it? https://github.com/mina86/linux.git f-fs-fix Regardless, I’ll prepare a proper patchset within a few days. Maybe even now. -- Best regards ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»