From: Michal Nazarewicz <mina86@mina86.com>
To: Tal Shorer <tal.shorer@gmail.com>, linux-usb@vger.kernel.org
Cc: balbi@ti.com, gregkh@linuxfoundation.org, tal.shorer@gmail.com,
andrzej.p@samsung.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_mass_storage: use defined constant instead of numeric value
Date: Fri, 27 Feb 2015 13:22:43 +0100 [thread overview]
Message-ID: <xa1tk2z3y25o.fsf@mina86.com> (raw)
In-Reply-To: <1424976170-2361-1-git-send-email-tal.shorer@gmail.com>
On Thu, Feb 26 2015, Tal Shorer <tal.shorer@gmail.com> wrote:
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> drivers/usb/gadget/function/f_mass_storage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
> index 811929c..6d5ca2b 100644
> --- a/drivers/usb/gadget/function/f_mass_storage.c
> +++ b/drivers/usb/gadget/function/f_mass_storage.c
> @@ -1085,7 +1085,7 @@ static int do_inquiry(struct fsg_common *common, struct fsg_buffhd *bh)
> if (!curlun) { /* Unsupported LUNs are okay */
> common->bad_lun_okay = 1;
> memset(buf, 0, 36);
> - buf[0] = 0x7f; /* Unsupported, no device-type */
> + buf[0] = TYPE_NO_LUN; /* Unsupported, no device-type */
> buf[4] = 31; /* Additional length */
> return 36;
> }
> --
> 2.2.2
>
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--
prev parent reply other threads:[~2015-02-27 12:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 18:42 [PATCH] usb: gadget: f_mass_storage: use defined constant instead of numeric value Tal Shorer
2015-02-27 12:22 ` Michal Nazarewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa1tk2z3y25o.fsf@mina86.com \
--to=mina86@mina86.com \
--cc=andrzej.p@samsung.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tal.shorer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox