* [PATCH] usb: gadget: f_mass_storage: use defined constant instead of numeric value
@ 2015-02-26 18:42 Tal Shorer
2015-02-27 12:22 ` Michal Nazarewicz
0 siblings, 1 reply; 2+ messages in thread
From: Tal Shorer @ 2015-02-26 18:42 UTC (permalink / raw)
To: linux-usb; +Cc: balbi, gregkh, mina86, tal.shorer, andrzej.p, linux-kernel
Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
drivers/usb/gadget/function/f_mass_storage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
index 811929c..6d5ca2b 100644
--- a/drivers/usb/gadget/function/f_mass_storage.c
+++ b/drivers/usb/gadget/function/f_mass_storage.c
@@ -1085,7 +1085,7 @@ static int do_inquiry(struct fsg_common *common, struct fsg_buffhd *bh)
if (!curlun) { /* Unsupported LUNs are okay */
common->bad_lun_okay = 1;
memset(buf, 0, 36);
- buf[0] = 0x7f; /* Unsupported, no device-type */
+ buf[0] = TYPE_NO_LUN; /* Unsupported, no device-type */
buf[4] = 31; /* Additional length */
return 36;
}
--
2.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: gadget: f_mass_storage: use defined constant instead of numeric value
2015-02-26 18:42 [PATCH] usb: gadget: f_mass_storage: use defined constant instead of numeric value Tal Shorer
@ 2015-02-27 12:22 ` Michal Nazarewicz
0 siblings, 0 replies; 2+ messages in thread
From: Michal Nazarewicz @ 2015-02-27 12:22 UTC (permalink / raw)
To: Tal Shorer, linux-usb; +Cc: balbi, gregkh, tal.shorer, andrzej.p, linux-kernel
On Thu, Feb 26 2015, Tal Shorer <tal.shorer@gmail.com> wrote:
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> drivers/usb/gadget/function/f_mass_storage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
> index 811929c..6d5ca2b 100644
> --- a/drivers/usb/gadget/function/f_mass_storage.c
> +++ b/drivers/usb/gadget/function/f_mass_storage.c
> @@ -1085,7 +1085,7 @@ static int do_inquiry(struct fsg_common *common, struct fsg_buffhd *bh)
> if (!curlun) { /* Unsupported LUNs are okay */
> common->bad_lun_okay = 1;
> memset(buf, 0, 36);
> - buf[0] = 0x7f; /* Unsupported, no device-type */
> + buf[0] = TYPE_NO_LUN; /* Unsupported, no device-type */
> buf[4] = 31; /* Additional length */
> return 36;
> }
> --
> 2.2.2
>
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-27 12:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-26 18:42 [PATCH] usb: gadget: f_mass_storage: use defined constant instead of numeric value Tal Shorer
2015-02-27 12:22 ` Michal Nazarewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox