From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753145AbdENLdj (ORCPT ); Sun, 14 May 2017 07:33:39 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:37994 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752351AbdENLdf (ORCPT ); Sun, 14 May 2017 07:33:35 -0400 From: Michal Nazarewicz To: Geliang Tang , Felipe Balbi , Greg Kroah-Hartman , Vincent Pelletier , Felix =?utf-8?Q?H=C3=A4dicke?= , Dan Carpenter , Jim Lin Cc: Geliang Tang , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: f_fs: use memdup_user In-Reply-To: <694b8a4beb2ec1e087321bc423e5cd0c69e5a717.1494576863.git.geliangtang@gmail.com> Organization: http://mina86.com/ References: <908fa521decaf3703e172c3734c0d498741f3ddb.1494580404.git.geliangtang@gmail.com> <694b8a4beb2ec1e087321bc423e5cd0c69e5a717.1494576863.git.geliangtang@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& OpenPGP: id=AC1F5F5CD41888F8CC8458582060401250751FF4; url=http://mina86.com/mina86.pub X-Hashcash: 1:20:170514:geliangtang@gmail.com::E9bbm2cX2J0kuXcl:00000000000000000000000000000000000000000pI7 X-Hashcash: 1:20:170514:linux-usb@vger.kernel.org::OLaOkdsjQlw4O9jE:0000000000000000000000000000000000000t1K X-Hashcash: 1:20:170514:geliangtang@gmail.com::wamegjN4Kx8WXV+j:00000000000000000000000000000000000000001fn1 X-Hashcash: 1:20:170514:gregkh@linuxfoundation.org::hwZ8v7RZgfcnYFKD:000000000000000000000000000000000001jb5 X-Hashcash: 1:20:170514:dan.carpenter@oracle.com::280Yf02AETabGepd:00000000000000000000000000000000000002nwD X-Hashcash: 1:20:170514:felixhaedicke@web.de::N6E1ltkgeClXfWwW:000000000000000000000000000000000000000004vPX X-Hashcash: 1:20:170514:linux-kernel@vger.kernel.org::u3K8Z8fCEUe3HMhx:0000000000000000000000000000000003yhm X-Hashcash: 1:20:170514:jilin@nvidia.com::dxtnK9FQ3FDgVBKr:070jB X-Hashcash: 1:20:170514:balbi@kernel.org::7o2kGXWs7uyVp1Xf:05BpI X-Hashcash: 1:20:170514:plr.vincent@gmail.com::OEkXujHog6hcTNT5:00000000000000000000000000000000000000008hQJ Date: Sun, 14 May 2017 13:33:29 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4EBXpqu016903 On Sat, May 13 2017, Geliang Tang wrote: > Use memdup_user() helper instead of open-coding to simplify the code. > > Signed-off-by: Geliang Tang Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/function/f_fs.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > index 71dd27c..5754538 100644 > --- a/drivers/usb/gadget/function/f_fs.c > +++ b/drivers/usb/gadget/function/f_fs.c > @@ -3692,14 +3692,9 @@ static char *ffs_prepare_buffer(const char __user *buf, size_t len) > if (unlikely(!len)) > return NULL; > > - data = kmalloc(len, GFP_KERNEL); > - if (unlikely(!data)) > - return ERR_PTR(-ENOMEM); > - > - if (unlikely(copy_from_user(data, buf, len))) { > - kfree(data); > - return ERR_PTR(-EFAULT); > - } > + data = memdup_user(buf, len); > + if (unlikely(IS_ERR(data))) > + return data; > > pr_vdebug("Buffer from user space:\n"); > ffs_dump_mem("", data, len); -- Best regards ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»