From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757350AbcIVOXE (ORCPT ); Thu, 22 Sep 2016 10:23:04 -0400 Received: from mail-lf0-f46.google.com ([209.85.215.46]:36567 "EHLO mail-lf0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757312AbcIVOXC (ORCPT ); Thu, 22 Sep 2016 10:23:02 -0400 From: Michal Nazarewicz To: Daniel Wagner , linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Daniel Wagner , Felipe Balbi , Greg Kroah-Hartman Subject: Re: [PATCH] usb: gadget: f_fs: use complete() instead complete_all() In-Reply-To: <1474552313-29257-1-git-send-email-wagi@monom.org> Organization: http://mina86.com/ References: <1474552313-29257-1-git-send-email-wagi@monom.org> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.2 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:160922:wagi@monom.org::aUmBcHZIdkKUfrRH:0000wNY X-Hashcash: 1:20:160922:gregkh@linuxfoundation.org::JyCJ7hn2w1ZnpubC:000000000000000000000000000000000000g7r X-Hashcash: 1:20:160922:balbi@kernel.org::OUCMNte0mU8EFAn5:02Lgf X-Hashcash: 1:20:160922:daniel.wagner@bmw-carit.de::/tJLk+epnC41hHQg:000000000000000000000000000000000001AWQ X-Hashcash: 1:20:160922:linux-kernel@vger.kernel.org::K1FWx/lVYx7puTw/:0000000000000000000000000000000009J0P X-Hashcash: 1:20:160922:linux-usb@vger.kernel.org::wdVvXMWhTHtPAUs9:00000000000000000000000000000000000075Wc Date: Thu, 22 Sep 2016 16:22:57 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8MEN8Mh014958 On Thu, Sep 22 2016, Daniel Wagner wrote: > From: Daniel Wagner > > There is only one waiter for the completion, therefore there > is no need to use complete_all(). Let's make that clear by > using complete() instead of complete_all(). > > The usage pattern of the completion is: > > waiter context waker context > reinit_completion() > usb_esp_queue() > wait_for_completion_interruptible() > > ffs_ep0_complete() > complete() > > Signed-off-by: Daniel Wagner > Cc: Felipe Balbi > Cc: Michal Nazarewicz Acked-by: Michal Nazarewicz > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > --- > drivers/usb/gadget/function/f_fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > index 5c8429f..0c29039 100644 > --- a/drivers/usb/gadget/function/f_fs.c > +++ b/drivers/usb/gadget/function/f_fs.c > @@ -211,7 +211,7 @@ static void ffs_ep0_complete(struct usb_ep *ep, struct usb_request *req) > { > struct ffs_data *ffs = req->context; > > - complete_all(&ffs->ep0req_completion); > + complete(&ffs->ep0req_completion); > } > > static int __ffs_ep0_queue_wait(struct ffs_data *ffs, char *data, size_t len) > -- > 2.7.4 -- Best regards ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»