From: Michal Nazarewicz <mina86@mina86.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>,
Vitaly Andrianov <vitalya@ti.com>
Cc: m.szyprowski@samsung.com, kyungmin.park@samsung.com,
arnd@arndb.de, linux-kernel@vger.kernel.org,
linux-keystone@list.ti.com, Cyril Chemparathy <cyril@ti.com>
Subject: Re: [linux-keystone] [PATCH v2] drivers: cma: fix addressing on PAE machines
Date: Tue, 04 Dec 2012 14:07:53 +0100 [thread overview]
Message-ID: <xa1tsj7m3qza.fsf@mina86.com> (raw)
In-Reply-To: <50BD9C45.7070501@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]
> On Monday 03 December 2012 09:16 PM, Vitaly Andrianov wrote:
>> This patch fixes a couple of bugs that otherwise impair CMA functionality on
>> PAE machines:
>>
>> - alignment must be a 64-bit type when running on systems with 64-bit
>> physical addresses. If this is not the case, the limit calculation thunks
>> allocations down to an address range < 4G.
>>
>> - The allocated range check is removed. On 32bit ARM kernel with LPAE
>> enabled the base may be allocated outside the fist 4GB of physical
>> memory (keystone SoC for example).
On Tue, Dec 04 2012, Santosh Shilimkar wrote:
> Any reason you have clubbed two fixes in one patch. Its better to keep
> the two fixes separate patches.
They are all related to the very same issue, and what the whole patch
does is change the type used to store physical addresses from unsigned
long to phys_addr_t. This is really a single change.
>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>> Signed-off-by: Cyril Chemparathy <cyril@ti.com>
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2.2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-12-04 13:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 15:46 [PATCH v2] drivers: cma: fix addressing on PAE machines Vitaly Andrianov
2012-12-03 18:19 ` Michal Nazarewicz
2012-12-04 6:46 ` [linux-keystone] " Santosh Shilimkar
2012-12-04 13:07 ` Michal Nazarewicz [this message]
2012-12-04 15:00 ` Santosh Shilimkar
2012-12-04 19:04 ` Michal Nazarewicz
2012-12-04 21:03 ` Andrianov, Vitaly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa1tsj7m3qza.fsf@mina86.com \
--to=mina86@mina86.com \
--cc=arnd@arndb.de \
--cc=cyril@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-keystone@list.ti.com \
--cc=m.szyprowski@samsung.com \
--cc=santosh.shilimkar@ti.com \
--cc=vitalya@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox