From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758388AbcG0UDp (ORCPT ); Wed, 27 Jul 2016 16:03:45 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:37696 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757866AbcG0UDl convert rfc822-to-8bit (ORCPT ); Wed, 27 Jul 2016 16:03:41 -0400 From: Michal Nazarewicz To: "Felipe F. Tonello" , linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Felipe Balbi , Baolin Wang , Andrzej Pietrasiewicz Subject: Re: [PATCH 8/9] usb: gadget: f_hid: use free_ep_req() In-Reply-To: <20160726191200.18943-9-eu@felipetonello.com> Organization: http://mina86.com/ References: <20160726191200.18943-1-eu@felipetonello.com> <20160726191200.18943-9-eu@felipetonello.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:160727:andrzej.p@samsung.com::Xr8LfVuZk+YBOadj:00000000000000000000000000000000000000001H5G X-Hashcash: 1:20:160727:linux-usb@vger.kernel.org::fKs0zzF7MiWNrrNr:0000000000000000000000000000000000001fTm X-Hashcash: 1:20:160727:balbi@kernel.org::K5i4VKWROOA6YAd0:03Nnk X-Hashcash: 1:20:160727:linux-kernel@vger.kernel.org::DNbG9dDP5RbAE+Sj:0000000000000000000000000000000001y1l X-Hashcash: 1:20:160727:eu@felipetonello.com::wdbc+1nW2q4F1hHv:000000000000000000000000000000000000000003Z17 X-Hashcash: 1:20:160727:baolin.wang@linaro.org::qzPgM1o6blQK+weW:0000000000000000000000000000000000000007/7n Date: Wed, 27 Jul 2016 22:03:38 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26 2016, Felipe F. Tonello wrote: > We should always use free_ep_req() when allocating requests with > alloc_ep_req(). > > Signed-off-by: Felipe F. Tonello Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/function/f_hid.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c > index e82a7468252e..a010496e4e05 100644 > --- a/drivers/usb/gadget/function/f_hid.c > +++ b/drivers/usb/gadget/function/f_hid.c > @@ -671,11 +671,8 @@ fail_free_descs: > usb_free_all_descriptors(f); > fail: > ERROR(f->config->cdev, "hidg_bind FAILED\n"); > - if (hidg->req != NULL) { > - kfree(hidg->req->buf); > - if (hidg->in_ep != NULL) > - usb_ep_free_request(hidg->in_ep, hidg->req); > - } > + if (hidg->req != NULL) > + free_ep_req(hidg->in_ep, hidg->req); > > return status; > } > @@ -904,8 +901,7 @@ static void hidg_unbind(struct usb_configuration *c, struct usb_function *f) > > /* disable/free request and end point */ > usb_ep_disable(hidg->in_ep); > - kfree(hidg->req->buf); > - usb_ep_free_request(hidg->in_ep, hidg->req); > + free_ep_req(hidg->in_ep, hidg->req); > > usb_free_all_descriptors(f); > } > -- > 2.9.0 > -- Best regards ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»