From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A51D374192 for ; Sat, 27 Jun 2026 06:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782542456; cv=none; b=QpzPXeV0lNW62aRxyiD1MbtJMrfOsoEIlWadv7JhMKcWMZYlDAWPnJ1WUQ2rspDvHydDrd0/DnTWh+8wk3FpC4gn/LrirUJZ14vN02p8mMH7bViEzKNRNwl5s5fhhKOsXz2pG89N/R1TbcJYIWK4rpdUQl7EE1tfOMnFDivPWyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782542456; c=relaxed/simple; bh=4lxEbe1Kcf5HJ3vZXPZHCnhc+3o+B9n10H9oF7tgbYE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RNwyOGecGEu8AXgIYJKp6cffNzi9IB03xiavBf+Gp92oU/Qq6wQcFxBn+LbRfY90DWAJ7tgGBKTXT45kAcCCNHKoFuJa3R8SQjcYOC6sTSnkWgwKnyrqauAAWLxB/1b4YSc+GEz3TIb9xBhcK32Iux+Hmqi8XO97uwpPXB3zh0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KKWelkl8; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KKWelkl8" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-49241dbf9c1so14542595e9.2 for ; Fri, 26 Jun 2026 23:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782542454; x=1783147254; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4lxEbe1Kcf5HJ3vZXPZHCnhc+3o+B9n10H9oF7tgbYE=; b=KKWelkl8fXpcAicR3T+rbUsB/ccwCG3kA+t3qgLbECW9HeMVh6GEehS/XgnTlcBmIT YNAV+1QCXXOv2cPaJgHT16+1a2h+2wbH9+YwE0GgMC6MYqkeYCEiXwDD5q0sgsx4wgDC Pxf2+DoVCyymVm6svFB4Wu0WKRRwWISowyBaDLeru/D6vhljzlnhprgAX6Ic8Z3QJeOQ p6zTiAOisKfL5WL9pcVaX71Mh6g7fTG/R5Hs1rO2h3LIH1LA831qjWT4mNiFi0A/CnAB FYNwOyzWAPHe0S3NryurZgnX7JuoP64w+sfUDeJn8U24+hVwwNxKxtpev7AEaFkA8YLX rq3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782542454; x=1783147254; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4lxEbe1Kcf5HJ3vZXPZHCnhc+3o+B9n10H9oF7tgbYE=; b=i03c5fVCm4cay2wqmlE6AsJi6FUwjjPPjucmu6JfY/+17o2JCkhtEZgK5JhGKKiDpN wQD4lckT9px7rrdjAEuBiM1h0cPdaY39Cjm+hlAIyuKZeDwtCfhiD4mJj9MlGduLRiYa QL2YQ6TFLR79DqqdpoCSOxOejcuSv3W/bt7m5OeFt/6advFCZF1jh4a/sbTJvxinefMt lO1rONonMBVwh0EeDyJROgtB9rDKA8BEcPTtJEdOWVhXkBGj+3qH/P80Osot4wPOGK/I sUr39jCEL6ftqBJib/Dp7FE6CEyx/BIBqNCwlMmEH/EOh0Dk6Yl4/2Ikz2zGhtugBGm9 1sBQ== X-Forwarded-Encrypted: i=1; AFNElJ9HfA5pDEuJ7/5tWq5I6CLwR94OpE+VEFKZQ4MBVhv+c7F0j2Qi49YlvM3kK782ufjeF7eyb5ad27xGuRU=@vger.kernel.org X-Gm-Message-State: AOJu0YzWunsfpKt91UUzbXiggqX6Nko0w5y6rFGNccQZiMOTz6O8SVp5 yZR+aOYLPAHHGx6oIgzZg0qjxBqy5I+nF3A/IUqrxSFLe5JJi4d082YM X-Gm-Gg: AfdE7cn181QZyDcxhdNgGTs+KCwae3/5PJpp4MCICGytTMTIg45KqzTbAem21+IsZoQ oJZ99fQgaRt1M1fablR9ex/+tQTkd0ye80VmeM7+W8rJedV9DyRiz0UVkwIPD5y1/XS9FjbZ9vk 0AWY9iNyzTdyFSnKAcwvWEu2PyvaFIo8bLwDQ7FPuZF27OCkXGG49fWDXyCetWqYdLlrvOCx3oL s8wPHA7PLpXShgJHB+C9V0hUJJu8jnXXonqjx2YI+Z5gyx76zLPfj6yubNJb+8ikcnLhJ8arAUg VaR3Zv1jgaPLHwY2jEdXXxOQlINZhsYGpqqZJ97RAK4JWmpFEX/q86In/1msaRqdi9phcdb+u2S 1IGpdlLthf3ez0TAZHMhGhjqOUhn790vXVyWkwgyOsssrFO2pDQ8HdAa5k3p+IncPXzz4opvlKw 3oqctPz4ocVcvytQirYjCD0dhTrmCjCj96zcyRNCQSA+3s5HrFsoi41EQuhBPgvMh0OWlCo+qRX 3TR X-Received: by 2002:a05:600d:6454:10b0:490:e243:4806 with SMTP id 5b1f17b1804b1-49266866378mr115051425e9.9.1782542453864; Fri, 26 Jun 2026 23:40:53 -0700 (PDT) Received: from jernej-laptop.localnet ([188.159.248.16]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49269002511sm131006755e9.8.2026.06.26.23.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 23:40:53 -0700 (PDT) From: Jernej =?UTF-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Pengpeng Hou Cc: pengpeng@iscas.ac.cn, Samuel Holland , Philipp Zabel , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bus: sunxi-rsb: fail hardware init on soft-reset timeout Date: Sat, 27 Jun 2026 08:40:52 +0200 Message-ID: In-Reply-To: <20260625003416.15841-1-pengpeng@iscas.ac.cn> References: <20260625003416.15841-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dne =C4=8Detrtek, 25. junij 2026 ob 02:34:16 Srednjeevropski poletni =C4=8D= as je Pengpeng Hou napisal(a): > sunxi_rsb_hw_init() issues a controller soft reset and waits for the reset > bit to clear, but it ignores readl_poll_timeout()'s return value. >=20 > If the controller never leaves reset, probe can continue to publish child > devices and system resume can report success without a usable RSB > controller. >=20 > Return the timeout error, assert reset again, and disable the clock before > leaving the hardware-init path. >=20 > Signed-off-by: Pengpeng Hou Acked-by: Jernej Skrabec Best regards, Jernej