* [PATCH] sched: core: Optimize the structure of 'tg_cfs_schedulable_down' function
@ 2023-03-19 20:02 Li kunyu
2023-03-20 22:48 ` Benjamin Segall
0 siblings, 1 reply; 2+ messages in thread
From: Li kunyu @ 2023-03-19 20:02 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman, bristot, vschneid
Cc: linux-kernel, Li kunyu
Optimize if branches and define in the branch statement
block parent_quota variable.
Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
kernel/sched/core.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 488655f2319f..7e8535d2e36d 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -10915,15 +10915,12 @@ static int tg_cfs_schedulable_down(struct task_group *tg, void *data)
{
struct cfs_schedulable_data *d = data;
struct cfs_bandwidth *cfs_b = &tg->cfs_bandwidth;
- s64 quota = 0, parent_quota = -1;
+ s64 quota = RUNTIME_INF;
- if (!tg->parent) {
- quota = RUNTIME_INF;
- } else {
+ if (tg->parent) {
struct cfs_bandwidth *parent_b = &tg->parent->cfs_bandwidth;
-
+ s64 parent_quota = parent_b->hierarchical_quota;
quota = normalize_cfs_quota(tg, d);
- parent_quota = parent_b->hierarchical_quota;
/*
* Ensure max(child_quota) <= parent_quota. On cgroup2,
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sched: core: Optimize the structure of 'tg_cfs_schedulable_down' function
2023-03-19 20:02 [PATCH] sched: core: Optimize the structure of 'tg_cfs_schedulable_down' function Li kunyu
@ 2023-03-20 22:48 ` Benjamin Segall
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Segall @ 2023-03-20 22:48 UTC (permalink / raw)
To: Li kunyu
Cc: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, mgorman, bristot, vschneid, linux-kernel
Li kunyu <kunyu@nfschina.com> writes:
> Optimize if branches and define in the branch statement
> block parent_quota variable.
It's not an optimization; it is arguably a slight style improvement.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
> kernel/sched/core.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 488655f2319f..7e8535d2e36d 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -10915,15 +10915,12 @@ static int tg_cfs_schedulable_down(struct task_group *tg, void *data)
> {
> struct cfs_schedulable_data *d = data;
> struct cfs_bandwidth *cfs_b = &tg->cfs_bandwidth;
> - s64 quota = 0, parent_quota = -1;
> + s64 quota = RUNTIME_INF;
>
> - if (!tg->parent) {
> - quota = RUNTIME_INF;
> - } else {
> + if (tg->parent) {
> struct cfs_bandwidth *parent_b = &tg->parent->cfs_bandwidth;
> -
> + s64 parent_quota = parent_b->hierarchical_quota;
> quota = normalize_cfs_quota(tg, d);
> - parent_quota = parent_b->hierarchical_quota;
>
> /*
> * Ensure max(child_quota) <= parent_quota. On cgroup2,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-20 22:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-19 20:02 [PATCH] sched: core: Optimize the structure of 'tg_cfs_schedulable_down' function Li kunyu
2023-03-20 22:48 ` Benjamin Segall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox