From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758851AbcHaUJp (ORCPT ); Wed, 31 Aug 2016 16:09:45 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:58276 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752513AbcHaUJm (ORCPT ); Wed, 31 Aug 2016 16:09:42 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=mlrN+SIfUFF8s5d/SahNM2M9Iw9AFqiM HJqVy6XMEoOjwXnxcxjCK06fuZ0iEQcgsWKpu47jv2ZktDofxVsZPa7X9CBWXoLX 13auzasZLG/XOQitatir27QPz7TIbP93MdZrEudNLhXl+nQNQMRXVBEbLTCeWcUE NScEcK2RB28= From: Junio C Hamano To: Joe Perches Cc: git@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] git-send-email: Add ability to cc: any "bylines" in the commit message References: <1472672344.4176.32.camel@perches.com> Date: Wed, 31 Aug 2016 13:09:38 -0700 In-Reply-To: <1472672344.4176.32.camel@perches.com> (Joe Perches's message of "Wed, 31 Aug 2016 12:39:04 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: D9993684-6FB6-11E6-A9C2-F7BB12518317-77302942!pb-smtp1.pobox.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches writes: > On Wed, 2016-08-31 at 12:34 -0700, Junio C Hamano wrote: >> Joe Perches writes: >> > Many commits have various forms of bylines similar to >> A missing blank line (I can tweak while queuing). > [] >> > + next if $suppress_cc{'bylines'} and $what !~ /Signed-off-by/i and $what =~ /by$/i; >> Having to keep this /by$/i in sync with whatever definition of >> bylines is will be error prone. How about doing it in this way? >> >> # Now parse the message body >> + my $bypat = r/[\w-]+-by/; >> while (<$fh>) { >> ... >> if (/^(Signed-off-by|Cc|$bypat): (.*)$/i) { >> ... >> next if $suppress_cc{'bodycc'} and $what =~ /Cc/i; >> + next if $suppress_cc{'bylines'} and >> + $what !~ /^Signed-off-by/i and >> + $what =~ /^$bypat/i; >> >> Other than that, looking good. > > Sure, whatever you want, do you want a v3 from me or can > you fix it up however you want? This topic is not my itch, so "however I want" would not be a good instruction to me--The lazy one in me would be tempted to say "ok, then I'd drop it altogether" ;-) I am sure the typo "[^\s]+[\w-]by" in the one we just saw was merely because you rushed it out without double checking. We are in pre-release feature freeze so there is no need to rush. I'd prefer to see a final version that is carefully proof-read by the author. Thanks.