From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1869AC33C9A for ; Mon, 6 Jan 2020 07:43:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E21E7215A4 for ; Mon, 6 Jan 2020 07:43:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gKSoZr/o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726199AbgAFHn2 (ORCPT ); Mon, 6 Jan 2020 02:43:28 -0500 Received: from mail-pg1-f201.google.com ([209.85.215.201]:55920 "EHLO mail-pg1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbgAFHn1 (ORCPT ); Mon, 6 Jan 2020 02:43:27 -0500 Received: by mail-pg1-f201.google.com with SMTP id v30so33710389pga.22 for ; Sun, 05 Jan 2020 23:43:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=jO5A+N0h1VUx5wWr6Ly4SVQVvrkMeU+RIQPrlwxnXKI=; b=gKSoZr/ov1hUV3VoGmhKfRYwayKxw9K5wvIWSIXrdbYhn5nVmJP1g00w+sP1RjNIKq yKdS60v/h6oY0NUo8NYKXgoatPCD8fkYKzY1z0nxMqp8mf9AwxtNgeGE+KP+bZrUHH3O InGfAJiqTOVNPUVLSh3zM9F80Ew9f2P1JBrolGaVwWQZjUB0h6wU+y4pNbHTLxVCy9du YYDmdxJBA5KIXntyQ/MNXllQYbIsYoaJmEc15wpTdrqe2HWczrcnSaSkQrZi7UFr8lda i2W1WVhtCE9kEHmGqSPJNWOFbvyRFii/kCqFWfB6UcXwnqtuUso7UuTIpuiJh/hMvAFq eXiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=jO5A+N0h1VUx5wWr6Ly4SVQVvrkMeU+RIQPrlwxnXKI=; b=D9oO/Z5Kn+laz1bLs8tZwLoEdqZMxIF1hfzDg+qAqr1ICzuIgFUGOqEaVm9teiSr+a JlSSR8d9IhZPeKdp+XNC1V5iKIlLeURr4k+Whgb6miOKv+SVOqVVdsq+z0gy35h3nZvE rHLXgedpX6OBpsa+DYI7925pBRGquec5smCHf7zov/6sRyuAYezEeL09l1dj5JDbvR8L IqRTKA5QVNNcfB/Y6KaOA54Hej4V8qvYAF75s4nwajQ+PMxCKEQGcJtdTVfbcvkZsV0a fAdTeyi7+GzXL+DYzxWOCg8XDCZg5UxMiJSexnDaKhDQJ6fqzYCZCwezCfFD4Q4cxg0n NUMw== X-Gm-Message-State: APjAAAURs6/LwdRImUsFyzDoC5LyirKeRgCDLUXblwKSPkUhC+bFmLZA BUbSVIuSno+V1qwTqXIr9h2gS43Pd/Gt X-Google-Smtp-Source: APXvYqyJhyqaS1b5r5/akYnlROnDPMiz7QrKAihuxtQ4RvX18vsqnFjr7V/LNoV4wFO/MCb12hnSoDxwGgFA X-Received: by 2002:a65:6916:: with SMTP id s22mr106609055pgq.244.1578296606813; Sun, 05 Jan 2020 23:43:26 -0800 (PST) Date: Sun, 05 Jan 2020 23:43:24 -0800 In-Reply-To: <20200104150238.19834-5-masahiroy@kernel.org> Message-Id: Mime-Version: 1.0 References: <20200104150238.19834-1-masahiroy@kernel.org> <20200104150238.19834-5-masahiroy@kernel.org> Subject: Re: [PATCH v2 04/13] initramfs: rename gen_initramfs_list.sh to gen_initramfs.sh From: Greg Thelen To: Masahiro Yamada , linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Andrew Morton , Sam Ravnborg , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Masahiro Yamada wrote: > The comments in usr/Makefile wrongly refer to the script name (twice). > > Line 37: > # The dependency list is generated by gen_initramfs.sh -l > > Line 54: > # 4) Arguments to gen_initramfs.sh changes > > There does not exist such a script. > > I was going to fix the comments, but after some consideration, I thought > "gen_initramfs.sh" would be more suitable than "gen_initramfs_list.sh" > because it generates an initramfs image in the common usage. > > The script generates a list that can be fed to gen_init_cpio only when > it is directly run without -o or -l option. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v2: None > > usr/Makefile | 2 +- > usr/{gen_initramfs_list.sh => gen_initramfs.sh} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename usr/{gen_initramfs_list.sh => gen_initramfs.sh} (100%) Will this break klibc? It might have a ref to the old name. https://git.kernel.org/pub/scm/libs/klibc/klibc.git/tree/usr/Kbuild#n55 > diff --git a/usr/Makefile b/usr/Makefile > index 55c942da01cd..e44a66b8c051 100644 > --- a/usr/Makefile > +++ b/usr/Makefile > @@ -24,7 +24,7 @@ $(obj)/initramfs_data.o: $(obj)/$(datafile_y) FORCE > # Generate the initramfs cpio archive > > hostprogs-y := gen_init_cpio > -initramfs := $(CONFIG_SHELL) $(srctree)/$(src)/gen_initramfs_list.sh > +initramfs := $(CONFIG_SHELL) $(srctree)/$(src)/gen_initramfs.sh > ramfs-input := $(if $(filter-out "",$(CONFIG_INITRAMFS_SOURCE)), \ > $(shell echo $(CONFIG_INITRAMFS_SOURCE)),-d) > ramfs-args := \ > diff --git a/usr/gen_initramfs_list.sh b/usr/gen_initramfs.sh > similarity index 100% > rename from usr/gen_initramfs_list.sh > rename to usr/gen_initramfs.sh