From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756158AbcHYEyp (ORCPT ); Thu, 25 Aug 2016 00:54:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45836 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754771AbcHYExm (ORCPT ); Thu, 25 Aug 2016 00:53:42 -0400 From: Yauheni Kaliuta To: kys@exchange.microsoft.com Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com, alexng@microsoft.com Subject: Re: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add regions References: <1472080943-29654-1-git-send-email-kys@exchange.microsoft.com> <1472080993-29694-1-git-send-email-kys@exchange.microsoft.com> <1472080993-29694-2-git-send-email-kys@exchange.microsoft.com> Date: Thu, 25 Aug 2016 07:53:53 +0300 In-Reply-To: <1472080993-29694-2-git-send-email-kys@exchange.microsoft.com> (kys@exchange.microsoft.com's message of "Wed, 24 Aug 2016 16:23:10 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 25 Aug 2016 04:53:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, kys! >>>>> On Wed, 24 Aug 2016 16:23:10 -0700, kys wrote: [...] > -static bool pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt) > +static int pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt) > { > struct list_head *cur; > struct hv_hotadd_state *has; > + struct hv_hotadd_gap *gap; > unsigned long residual, new_inc; > if (list_empty(&dm_device.ha_region_list)) One "return false;" left here. [...] > - if (has->covered_end_pfn != start_pfn) > - has->covered_end_pfn = start_pfn; > - > - return true; > - > + return 1; > } > - return false; > + return 0; > } [...] -- WBR, Yauheni Kaliuta