From: fche@redhat.com (Frank Ch. Eigler)
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@redhat.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Tom Zanussi <zanussi@us.ibm.com>,
Karim Yaghmour <karim@opersys.com>,
Paul Mundt <lethal@linux-sh.org>, Jes Sorensen <jes@sgi.com>,
Richard J Moore <richardj_moore@uk.ibm.com>,
"Martin J. Bligh" <mbligh@mbligh.org>,
Michel Dagenais <michel.dagenais@polymtl.ca>,
Douglas Niehaus <niehaus@eecs.ku.edu>,
ltt-dev@shafik.org, systemtap@sources.redhat.com
Subject: Re: [PATCH 3/16] LTTng 0.6.36 for 2.6.18 : Linux Kernel Markers
Date: 27 Nov 2006 21:23:17 -0500 [thread overview]
Message-ID: <y0mu00kpawa.fsf@ton.toronto.redhat.com> (raw)
In-Reply-To: <20061124215401.GD25048@Krystal>
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> writes:
> This patch adds the Linux Kernel Markers [...]
> Signed-off-by : Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
If it helps,
Acked-by: Frank Ch. Eigler <fche@redhat.com>
One question:
> [...]
> + /* Markers in modules. */
> + list_for_each_entry(mod, &modules, list) {
> + if (mod->license_gplok)
> + found += marker_set_probe_range(name, format, probe,
> + mod->markers, mod->markers+mod->num_markers);
> + }
> [...]
> +EXPORT_SYMBOL(marker_set_probe);
Are you sure the license_gplok check is necessary here? We should
consider encouraging non-gpl module writers to instrument their code,
to give users a slightly better chance of debugging problems.
- FChE
next prev parent reply other threads:[~2006-11-28 2:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-24 21:54 [PATCH 3/16] LTTng 0.6.36 for 2.6.18 : Linux Kernel Markers Mathieu Desnoyers
2006-11-28 2:23 ` Frank Ch. Eigler [this message]
2006-11-28 2:33 ` Mathieu Desnoyers
2006-11-28 5:40 ` Christoph Hellwig
2006-11-29 1:06 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y0mu00kpawa.fsf@ton.toronto.redhat.com \
--to=fche@redhat.com \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=hch@infradead.org \
--cc=jes@sgi.com \
--cc=karim@opersys.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@shafik.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mbligh@mbligh.org \
--cc=michel.dagenais@polymtl.ca \
--cc=mingo@redhat.com \
--cc=niehaus@eecs.ku.edu \
--cc=richardj_moore@uk.ibm.com \
--cc=systemtap@sources.redhat.com \
--cc=tglx@linutronix.de \
--cc=zanussi@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox