From: Linus Heckemann <linus@schreibt.jetzt>
To: Jason Gunthorpe <jgg@nvidia.com>, Min Ma <min.ma@amd.com>,
Lizhi Hou <lizhi.hou@amd.com>,
dri-devel@lists.freedesktop.org
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: amdxdna breaks suspend (was: Re: [PATCH v5 2/8] iommu: Remove IOMMU_DEV_FEAT_SVA)
Date: Fri, 16 Jan 2026 13:00:34 +0100 [thread overview]
Message-ID: <yga3445n4wt.fsf@localhost> (raw)
In-Reply-To: <20251230011916.GB23056@nvidia.com>
Jason Gunthorpe <jgg@nvidia.com> writes:
> On Thu, Dec 25, 2025 at 10:05:59PM +0100, Linus Heckemann wrote:
>> It appears the code removed here was not in fact entirely dead; my 2024
>> gpd win mini ("G1617-01", with a Ryzen 8840U) fails to suspend
>> correctly, and I bisected the issue to this commit.
>
> The only behavior change this patch had that could be relavent to a
> Ryzen was in drivers/accel/amdxdna/aie2_pci.c - are you using this
> driver?
>
> Prior to this patch amdxdna would have failed to load in configs
> without an iommu as iommu_dev_enable_feature() would have
> failed. After this patch it will load successfully.
>
> If so then that driver presmuably doesn't have working power
> management in your system.
You're right, blacklisting the amdxdna driver fixes suspend, thanks for
the pointer!
@Min Ma, Lizhi Hou, dri-devel: do you have any insight into why this
might be happening?
Cheers
Linus H
next prev parent reply other threads:[~2026-01-16 12:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 8:01 [PATCH v5 0/8] iommu: Remove IOMMU_DEV_FEAT_SVA/_IOPF Lu Baolu
2025-04-18 8:01 ` [PATCH v5 1/8] iommu/arm-smmu-v3: Put iopf enablement in the domain attach path Lu Baolu
2025-04-18 8:01 ` [PATCH v5 2/8] iommu: Remove IOMMU_DEV_FEAT_SVA Lu Baolu
2025-12-25 21:05 ` Linus Heckemann
2025-12-30 1:19 ` Jason Gunthorpe
2026-01-16 12:00 ` Linus Heckemann [this message]
2026-01-16 15:27 ` amdxdna breaks suspend (was: Re: [PATCH v5 2/8] iommu: Remove IOMMU_DEV_FEAT_SVA) Alex Deucher
2026-01-16 16:02 ` Jason Gunthorpe
2026-01-16 17:01 ` Lizhi Hou
2025-04-18 8:01 ` [PATCH v5 3/8] iommu/vt-d: Put iopf enablement in domain attach path Lu Baolu
2025-04-18 8:01 ` [PATCH v5 4/8] iommufd/selftest: " Lu Baolu
2025-04-18 8:01 ` [PATCH v5 5/8] dmaengine: idxd: Remove unnecessary IOMMU_DEV_FEAT_IOPF Lu Baolu
2025-04-18 8:01 ` [PATCH v5 6/8] uacce: " Lu Baolu
2025-04-18 8:01 ` [PATCH v5 7/8] iommufd: " Lu Baolu
2025-04-18 8:01 ` [PATCH v5 8/8] iommu: Remove iommu_dev_enable/disable_feature() Lu Baolu
2025-04-18 20:23 ` Nicolin Chen
2025-04-21 6:00 ` [PATCH v5 0/8] iommu: Remove IOMMU_DEV_FEAT_SVA/_IOPF Zhangfei Gao
2025-04-28 11:05 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yga3445n4wt.fsf@localhost \
--to=linus@schreibt.jetzt \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=min.ma@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox