* [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user"
@ 2025-07-16 9:35 Dishank Jogi
2025-07-16 9:43 ` David Hildenbrand
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Dishank Jogi @ 2025-07-16 9:35 UTC (permalink / raw)
To: Kees Cook, Andrew Morton, David Hildenbrand, Lorenzo Stoakes,
Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Ingo Molnar, Peter Zijlstra,
Juri Lelli, Vincent Guittot, Dietmar Eggemann, Steven Rostedt,
Ben Segall, Mel Gorman, Valentin Schneider, Christian Brauner,
linux-mm, linux-kernel
Cc: Dishank Jogi
Change the order of function qualifiers from 'noinline static' to 'static noinline'
in copy_clone_args_from_user for consistency with kernel coding style.
This is a non-functional change intended to improve readability and maintain
consistent ordering of qualifiers across the codebase.
Signed-off-by: Dishank Jogi <dishank.jogi@siqol.com>
---
kernel/fork.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/fork.c b/kernel/fork.c
index 1ee8eb11f38b..574ff0d983db 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -2743,7 +2743,7 @@ SYSCALL_DEFINE5(clone, unsigned long, clone_flags, unsigned long, newsp,
}
#endif
-noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs,
+static noinline int copy_clone_args_from_user(struct kernel_clone_args *kargs,
struct clone_args __user *uargs,
size_t usize)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user"
2025-07-16 9:35 [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user" Dishank Jogi
@ 2025-07-16 9:43 ` David Hildenbrand
2025-07-16 10:54 ` Lorenzo Stoakes
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: David Hildenbrand @ 2025-07-16 9:43 UTC (permalink / raw)
To: Dishank Jogi, Kees Cook, Andrew Morton, Lorenzo Stoakes,
Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Ingo Molnar, Peter Zijlstra,
Juri Lelli, Vincent Guittot, Dietmar Eggemann, Steven Rostedt,
Ben Segall, Mel Gorman, Valentin Schneider, Christian Brauner,
linux-mm, linux-kernel
On 16.07.25 11:35, Dishank Jogi wrote:
"" in patch subject is weird
> Change the order of function qualifiers from 'noinline static' to 'static noinline'
> in copy_clone_args_from_user for consistency with kernel coding style.
>
> This is a non-functional change intended to improve readability and maintain
> consistent ordering of qualifiers across the codebase.
Simplify to "No functional change intended." All the other stuff can be
dropped from this sentence IMHO -- I'd even drop the whole sentence.
>
> Signed-off-by: Dishank Jogi <dishank.jogi@siqol.com>
> ---
> kernel/fork.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 1ee8eb11f38b..574ff0d983db 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -2743,7 +2743,7 @@ SYSCALL_DEFINE5(clone, unsigned long, clone_flags, unsigned long, newsp,
> }
> #endif
>
> -noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs,
> +static noinline int copy_clone_args_from_user(struct kernel_clone_args *kargs,
> struct clone_args __user *uargs,
> size_t usize)
> {
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user"
2025-07-16 9:35 [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user" Dishank Jogi
2025-07-16 9:43 ` David Hildenbrand
@ 2025-07-16 10:54 ` Lorenzo Stoakes
2025-07-16 13:59 ` Liam R. Howlett
2025-07-17 23:38 ` Kees Cook
3 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Stoakes @ 2025-07-16 10:54 UTC (permalink / raw)
To: Dishank Jogi
Cc: Kees Cook, Andrew Morton, David Hildenbrand, Liam R. Howlett,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Valentin Schneider, Christian Brauner, linux-mm, linux-kernel
I'm not sure what the "'s are for, hopefully whoever merges this removes
them :)
On Wed, Jul 16, 2025 at 03:05:25PM +0530, Dishank Jogi wrote:
> Change the order of function qualifiers from 'noinline static' to 'static noinline'
> in copy_clone_args_from_user for consistency with kernel coding style.
>
> This is a non-functional change intended to improve readability and maintain
> consistent ordering of qualifiers across the codebase.
>
> Signed-off-by: Dishank Jogi <dishank.jogi@siqol.com>
This seems fine so:
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
> kernel/fork.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 1ee8eb11f38b..574ff0d983db 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -2743,7 +2743,7 @@ SYSCALL_DEFINE5(clone, unsigned long, clone_flags, unsigned long, newsp,
> }
> #endif
>
> -noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs,
> +static noinline int copy_clone_args_from_user(struct kernel_clone_args *kargs,
> struct clone_args __user *uargs,
> size_t usize)
> {
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user"
2025-07-16 9:35 [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user" Dishank Jogi
2025-07-16 9:43 ` David Hildenbrand
2025-07-16 10:54 ` Lorenzo Stoakes
@ 2025-07-16 13:59 ` Liam R. Howlett
2025-07-17 23:38 ` Kees Cook
3 siblings, 0 replies; 5+ messages in thread
From: Liam R. Howlett @ 2025-07-16 13:59 UTC (permalink / raw)
To: Dishank Jogi
Cc: Kees Cook, Andrew Morton, David Hildenbrand, Lorenzo Stoakes,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Valentin Schneider, Christian Brauner, linux-mm, linux-kernel
* Dishank Jogi <dishank.jogi@siqol.com> [250716 05:35]:
> Change the order of function qualifiers from 'noinline static' to 'static noinline'
> in copy_clone_args_from_user for consistency with kernel coding style.
>
> This is a non-functional change intended to improve readability and maintain
> consistent ordering of qualifiers across the codebase.
>
> Signed-off-by: Dishank Jogi <dishank.jogi@siqol.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> kernel/fork.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 1ee8eb11f38b..574ff0d983db 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -2743,7 +2743,7 @@ SYSCALL_DEFINE5(clone, unsigned long, clone_flags, unsigned long, newsp,
> }
> #endif
>
> -noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs,
> +static noinline int copy_clone_args_from_user(struct kernel_clone_args *kargs,
> struct clone_args __user *uargs,
> size_t usize)
> {
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user"
2025-07-16 9:35 [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user" Dishank Jogi
` (2 preceding siblings ...)
2025-07-16 13:59 ` Liam R. Howlett
@ 2025-07-17 23:38 ` Kees Cook
3 siblings, 0 replies; 5+ messages in thread
From: Kees Cook @ 2025-07-17 23:38 UTC (permalink / raw)
To: Andrew Morton, David Hildenbrand, Lorenzo Stoakes,
Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Ingo Molnar, Peter Zijlstra,
Juri Lelli, Vincent Guittot, Dietmar Eggemann, Steven Rostedt,
Ben Segall, Mel Gorman, Valentin Schneider, Christian Brauner,
linux-mm, linux-kernel, Dishank Jogi
Cc: Kees Cook
On Wed, 16 Jul 2025 15:05:25 +0530, Dishank Jogi wrote:
> Change the order of function qualifiers from 'noinline static' to 'static noinline'
> in copy_clone_args_from_user for consistency with kernel coding style.
>
> This is a non-functional change intended to improve readability and maintain
> consistent ordering of qualifiers across the codebase.
>
>
> [...]
I've tweaked the commit log and Subject and applied to for-next/execve, thanks!
[1/1] fork: reorder function qualifiers for copy_clone_args_from_user
https://git.kernel.org/kees/c/7f71195c15dc
Take care,
--
Kees Cook
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-07-17 23:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-16 9:35 [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user" Dishank Jogi
2025-07-16 9:43 ` David Hildenbrand
2025-07-16 10:54 ` Lorenzo Stoakes
2025-07-16 13:59 ` Liam R. Howlett
2025-07-17 23:38 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).