From: Vasily Gorbik <gor@linux.ibm.com>
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Joe Lawrence <joe.lawrence@redhat.com>,
stable@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390: reintroduce expoline dependence to scripts
Date: Tue, 21 Mar 2023 22:19:06 +0100 [thread overview]
Message-ID: <your-ad-here.call-01679433546-ext-8459@work.hours> (raw)
In-Reply-To: <20230316112809.7903-1-jirislaby@kernel.org>
On Thu, Mar 16, 2023 at 12:28:09PM +0100, Jiri Slaby (SUSE) wrote:
> Expolines depend on scripts/basic/fixdep. And build of expolines can now
> race with the fixdep build:
>
> make[1]: *** Deleting file 'arch/s390/lib/expoline/expoline.o'
> /bin/sh: line 1: scripts/basic/fixdep: Permission denied
> make[1]: *** [../scripts/Makefile.build:385: arch/s390/lib/expoline/expoline.o] Error 126
> make: *** [../arch/s390/Makefile:166: expoline_prepare] Error 2
>
> The dependence was removed in the below Fixes: commit. So reintroduce
> the dependence on scripts.
>
> Fixes: a0b0987a7811 ("s390/nospec: remove unneeded header includes")
> Cc: Joe Lawrence <joe.lawrence@redhat.com>
> Cc: stable@vger.kernel.org
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
> Cc: Sven Schnelle <svens@linux.ibm.com>
> Cc: linux-s390@vger.kernel.org
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> ---
> arch/s390/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/Makefile b/arch/s390/Makefile
> index b3235ab0ace8..ed646c583e4f 100644
> --- a/arch/s390/Makefile
> +++ b/arch/s390/Makefile
> @@ -162,7 +162,7 @@ vdso_prepare: prepare0
>
> ifdef CONFIG_EXPOLINE_EXTERN
> modules_prepare: expoline_prepare
> -expoline_prepare:
> +expoline_prepare: scripts
> $(Q)$(MAKE) $(build)=arch/s390/lib/expoline arch/s390/lib/expoline/expoline.o
> endif
> endif
> --
Applied, thank you.
prev parent reply other threads:[~2023-03-21 21:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <705ce64c-5f73-2ec8-e4bc-dd48c85f0498@kernel.org>
2023-03-16 11:28 ` [PATCH] s390: reintroduce expoline dependence to scripts Jiri Slaby (SUSE)
2023-03-21 21:19 ` Vasily Gorbik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=your-ad-here.call-01679433546-ext-8459@work.hours \
--to=gor@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jirislaby@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox