From: Vasily Gorbik <gor@linux.ibm.com>
To: Peter Oberparleiter <oberpar@linux.ibm.com>
Cc: Dinghao Liu <dinghao.liu@zju.edu.cn>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
Julian Wiedmann <jwi@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/cio: Fix a memleak in css_alloc_subchannel
Date: Tue, 10 Oct 2023 12:32:24 +0200 [thread overview]
Message-ID: <your-ad-here.call-01696933944-ext-3327@work.hours> (raw)
In-Reply-To: <bd38baa8-7b9d-4d89-9422-7e943d626d6e@linux.ibm.com>
On Thu, Oct 05, 2023 at 05:12:54PM +0200, Peter Oberparleiter wrote:
> On 21.09.2023 09:14, Dinghao Liu wrote:
> > When dma_set_coherent_mask() fails, sch->lock has not been
> > freed, which is allocated in css_sch_create_locks(), leading
> > to a memleak.
> >
> > Fixes: 4520a91a976e ("s390/cio: use dma helpers for setting masks")
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
>
> Looks good to me.
>
> Reviewed-by: Peter Oberparleiter <oberpar@linux.ibm.com>
Applied, thank you.
prev parent reply other threads:[~2023-10-10 10:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230921071412.13806-1-dinghao.liu@zju.edu.cn>
2023-09-22 12:17 ` [PATCH] s390/cio: Fix a memleak in css_alloc_subchannel Halil Pasic
2023-09-22 12:25 ` Cornelia Huck
2023-09-22 13:20 ` Halil Pasic
2023-09-22 19:15 ` Vineeth Vijayan
2023-09-24 17:58 ` Halil Pasic
2023-10-05 15:12 ` Peter Oberparleiter
2023-10-10 10:32 ` Vasily Gorbik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=your-ad-here.call-01696933944-ext-3327@work.hours \
--to=gor@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=hca@linux.ibm.com \
--cc=jwi@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox