From: Jes Sorensen <jes@wildopensource.com>
To: Greg Howard <ghoward@sgi.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Altix system controller communication driver
Date: 28 Jul 2004 11:11:17 -0400 [thread overview]
Message-ID: <yq0fz7c9nfu.fsf@wildopensource.com> (raw)
In-Reply-To: <Pine.SGI.4.58.0407271457240.1364@gallifrey.americas.sgi.com>
>>>>> "Greg" == Greg Howard <ghoward@sgi.com> writes:
Greg> Hi Andrew, The following patch
Greg> ("altix-system-controller-driver.patch") implements a driver
Greg> that allows user applications to access the system controllers
Greg> on SGI Altix machines. It applies on top of the 2.6.8-rc-mm1
Greg> patch.
Greg,
A few quick comments, there might be more, I just spotted these two
points quickly:
1) Please update the struct file_operations assignments to use
.owner THIS_MODULE, etc. instead of owner:
2) Always check the return values from copy_from_user and copy_to_user
to avoid userland feeing you bogus pointers.
Jes
next prev parent reply other threads:[~2004-07-28 15:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-27 20:07 [PATCH] Altix system controller communication driver Greg Howard
2004-07-28 15:11 ` Jes Sorensen [this message]
2004-07-28 15:57 ` Andrew Morton
2004-07-28 18:21 ` Sam Ravnborg
2004-07-29 19:46 ` Greg Howard
2004-07-28 22:11 ` Greg Howard
2004-07-28 23:00 ` Andrew Morton
2004-07-29 19:50 ` Greg Howard
2004-07-30 21:44 ` Greg Howard
2004-07-31 9:55 ` Christoph Hellwig
2004-08-01 0:55 ` Andrew Morton
2004-08-02 11:46 ` Greg Howard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq0fz7c9nfu.fsf@wildopensource.com \
--to=jes@wildopensource.com \
--cc=akpm@osdl.org \
--cc=ghoward@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox