public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@infradead.org>,
	linux-block@vger.kernel.org,
	linux-m68k <linux-m68k@lists.linux-m68k.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
Date: Thu, 11 Nov 2021 10:36:07 -0500	[thread overview]
Message-ID: <yq11r3mg1gm.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <CAMuHMdVdwwT5yQPpQ5Frr-Un5OMk9LX3sF_zocOejrouSjaO-w@mail.gmail.com> (Geert Uytterhoeven's message of "Thu, 11 Nov 2021 15:48:37 +0100")


Geert,

>> > sd 0:0:0:0: [sda] tag#0 CDB: Write(10) 2a 08 00 00 00 01 00 00 08 00
                                               ^^
                                               FUA

> sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't
> support DPO or FUA

The device is correct in rejecting the command, then. But I'm not sure
how the commit in question would cause us to inadvertently set that
flag...

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2021-11-11 15:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211104182201.83906-1-axboe@kernel.dk>
     [not found] ` <20211104182201.83906-5-axboe@kernel.dk>
     [not found]   ` <YYQoLzMn7+s9hxpX@infradead.org>
     [not found]     ` <2865c289-7014-2250-0f5b-a9ed8770d0ec@kernel.dk>
     [not found]       ` <YYQo4ougXZvgv11X@infradead.org>
     [not found]         ` <8c6163f4-0c0f-5254-5f79-9074f5a73cfe@kernel.dk>
     [not found]           ` <461c4758-2675-1d11-ac8a-6f25ef01d781@kernel.dk>
     [not found]             ` <YYQr3jl3avsuOUAJ@infradead.org>
     [not found]               ` <3d29a5ce-aace-6198-3ea9-e6f603e74aa1@kernel.dk>
     [not found]                 ` <YYQuyt2/y1MgzRi0@infradead.org>
     [not found]                   ` <87ee0091-9c2f-50e8-c8f2-dcebebb9de48@kernel.dk>
2021-11-11 12:58                     ` [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio() Geert Uytterhoeven
2021-11-11 13:19                       ` Martin K. Petersen
2021-11-11 14:48                         ` Geert Uytterhoeven
2021-11-11 15:36                           ` Martin K. Petersen [this message]
2021-11-11 21:35                           ` Michael Schmitz
2021-11-12  7:37                             ` Geert Uytterhoeven
2021-11-12 22:34                               ` Michael Schmitz
2021-11-13  7:02                                 ` Michael Schmitz
2021-11-13 10:06                                 ` Geert Uytterhoeven
2021-11-13 22:11                               ` Michael Schmitz
2021-11-11 13:44                       ` Ming Lei
2021-11-11 14:51                         ` Geert Uytterhoeven
2021-11-11 15:23                           ` Ming Lei
2021-11-11 22:17                             ` Jens Axboe
2021-11-12  0:44                               ` Ming Lei
2021-11-12  7:51                                 ` Geert Uytterhoeven
2021-11-15 19:23                                   ` Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq11r3mg1gm.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=geert@linux-m68k.org \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox