From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Rob Herring <robh@kernel.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
linux-scsi@vger.kernel.org, Meelis Roos <mroos@linux.ee>
Subject: Re: [PATCH] scsi: qlogicpti: Use of_node_name_eq for node name comparisons
Date: Wed, 13 Feb 2019 22:14:21 -0500 [thread overview]
Message-ID: <yq11s4bqcxe.fsf@oracle.com> (raw)
In-Reply-To: <20190213160829.3923-1-robh@kernel.org> (Rob Herring's message of "Wed, 13 Feb 2019 10:08:29 -0600")
Rob,
> - qpti->is_pti = strcmp(qpti->prom_name, "QLGC,isp");
> + qpti->is_pti = !of_node_name_eq(op->dev.of_node, "QLGC,isp");
The apparent polarity inversion made me blink but it appears to be
correct (is_pti is set if it's not an isp controller). Makes me wonder
if the driver is doing the right thing for a "SUNW,isp", though...
Meelis: Do you have anything that identifies itself as SUNW,isp?
In any case: Applied to 5.1/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-02-14 3:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 16:08 [PATCH] scsi: qlogicpti: Use of_node_name_eq for node name comparisons Rob Herring
2019-02-14 3:14 ` Martin K. Petersen [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-05 19:50 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11s4bqcxe.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox