From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1432233AbdDYQvl (ORCPT ); Tue, 25 Apr 2017 12:51:41 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:34800 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1432198AbdDYQvb (ORCPT ); Tue, 25 Apr 2017 12:51:31 -0400 To: Colin King Cc: Johannes Thumshirn , "James E . J . Bottomley" , "Martin K . Petersen" , fcoe-devel@open-fcoe.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: fcoe: make fcoe_e_d_tov and fcoe_r_a_tov static From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170424170418.9625-1-colin.king@canonical.com> Date: Tue, 25 Apr 2017 12:51:15 -0400 In-Reply-To: <20170424170418.9625-1-colin.king@canonical.com> (Colin King's message of "Mon, 24 Apr 2017 18:04:18 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin, > These module parameter variables don't need global scope, make them > static Applied to 4.12/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering