From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754580AbbCFMMX (ORCPT ); Fri, 6 Mar 2015 07:12:23 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:25600 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752801AbbCFMMV (ORCPT ); Fri, 6 Mar 2015 07:12:21 -0500 To: Tapasweni Pathak Cc: JBottomley@parallels.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] drivers: scsi: Remove null check on sdkp From: "Martin K. Petersen" Organization: Oracle Corporation References: <20150306023649.GA6316@kt-Inspiron-3542> Date: Fri, 06 Mar 2015 07:12:01 -0500 In-Reply-To: <20150306023649.GA6316@kt-Inspiron-3542> (Tapasweni Pathak's message of "Fri, 6 Mar 2015 08:06:49 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Tapasweni" == Tapasweni Pathak writes: Tapasweni> Remove null check on sdkp as it won't be null at this line. Thanks for the heads up. It's actually a merge snafu. The check is supposed to be if (!sdkp->ATO). I already have a patch in my queue to fix this. -- Martin K. Petersen Oracle Linux Engineering