From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Qianfeng Rong <rongqianfeng@vivo.com>
Cc: Nilesh Javali <njavali@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com (maintainer:QLOGIC
QLA2XXX FC-SCSI DRIVER,blamed_fixes:1/1=100%),
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Quinn Tran <qutran@marvell.com>,
himanshu.madhani@oracle.com,
Manish Rangankar <mrangankar@marvell.com>,
linux-scsi@vger.kernel.org (open list:QLOGIC QLA2XXX FC-SCSI
DRIVER), linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH 0/3] scsi: qla2xxx: Fix incorrect sign of error code
Date: Tue, 16 Sep 2025 22:06:41 -0400 [thread overview]
Message-ID: <yq1348lzvbp.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250905075446.381139-1-rongqianfeng@vivo.com> (Qianfeng Rong's message of "Fri, 5 Sep 2025 15:54:42 +0800")
Qianfeng,
> qla2x00_start_sp() returns only negative error codes or QLA_SUCCESS.
> Therefore, comparing its return value with positive error codes
> (e.g., if (_rval == EAGAIN)) causes logical errors.
Applied to 6.18/scsi-staging, thanks!
--
Martin K. Petersen
prev parent reply other threads:[~2025-09-17 2:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 7:54 [PATCH 0/3] scsi: qla2xxx: Fix incorrect sign of error code Qianfeng Rong
2025-09-05 7:54 ` [PATCH 1/3] scsi: qla2xxx: edif: " Qianfeng Rong
2025-09-05 7:54 ` [PATCH 2/3] scsi: qla2xxx: Fix incorrect sign of error code in START_SP_W_RETRIES() Qianfeng Rong
2025-09-05 7:54 ` [PATCH 3/3] scsi: qla2xxx: Fix incorrect sign of error code in qla_nvme_xmt_ls_rsp() Qianfeng Rong
2025-09-17 2:06 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1348lzvbp.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=himanshu.madhani@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mrangankar@marvell.com \
--cc=njavali@marvell.com \
--cc=qutran@marvell.com \
--cc=rongqianfeng@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox