From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Joel Granados <joel.granados@kernel.org>
Cc: Nicolas Bouchinet <nicolas.bouchinet@clip-os.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-scsi@vger.kernel.org, codalist@coda.cs.cmu.edu,
linux-nfs@vger.kernel.org,
Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>,
Joel Granados <j.granados@samsung.com>,
Clemens Ladisch <clemens@ladisch.de>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Jan Harkes <jaharkes@cs.cmu.edu>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>, Neil Brown <neilb@suse.de>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
Zhu Yanjun <yanjun.zhu@linux.dev>,
Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH v2 4/6] sysctl: Fixes scsi_logging_level bounds
Date: Mon, 03 Mar 2025 21:24:43 -0500 [thread overview]
Message-ID: <yq134ftv8h4.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <rgh2ffvmp2wlyupv6vw5s3qexuipgu6vdr2qsitgnbn6syk6ye@ln74xh26jdwp> (Joel Granados's message of "Mon, 3 Mar 2025 15:04:19 +0100")
Joel,
> 1. Having the upper bound be SYSCTL_INT_MAX is not necessary (as it is
> silently capped by proc_dointvec_minmax, but it is good to have as it
> adds to the understanding on what the range of the values are.
>
> 2. Having the lower bound capped by SYSCTL_ZERO is needed as it will
> prevent ppl trying to assigning negative values to the unsigned integer
>
> Let me know if you take this through the scsi subsystem so I know to
> drop it from sysctl
Applied to 6.15/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2025-03-04 2:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 9:58 [PATCH v2 0/6] Fixes multiple sysctl bound checks nicolas.bouchinet
2025-02-24 9:58 ` [PATCH v2 1/6] sysctl: Fixes idmap_cache_timeout bounds nicolas.bouchinet
2025-02-24 9:58 ` [PATCH v2 2/6] sysctl: Fixes nsm_local_state bounds nicolas.bouchinet
2025-02-24 14:38 ` Chuck Lever
2025-02-25 10:37 ` Nicolas Bouchinet
2025-03-03 14:12 ` Joel Granados
2025-03-03 21:20 ` Chuck Lever
2025-03-03 21:42 ` cel
2025-03-05 14:49 ` Joel Granados
2025-02-24 9:58 ` [PATCH v2 3/6] sysctl/coda: Fixes timeout bounds nicolas.bouchinet
2025-03-03 14:15 ` Joel Granados
2025-03-03 14:39 ` Jan Harkes
2025-03-05 14:47 ` Joel Granados
2025-03-06 10:40 ` Nicolas Bouchinet
2025-02-24 9:58 ` [PATCH v2 4/6] sysctl: Fixes scsi_logging_level bounds nicolas.bouchinet
2025-02-25 1:20 ` Martin K. Petersen
2025-02-25 10:47 ` Nicolas Bouchinet
2025-03-03 14:04 ` Joel Granados
2025-03-04 2:24 ` Martin K. Petersen [this message]
2025-03-05 14:44 ` Joel Granados
2025-02-24 9:58 ` [PATCH v2 5/6] sysctl/infiniband: Fixes infiniband sysctl bounds nicolas.bouchinet
2025-02-24 13:41 ` Leon Romanovsky
2025-03-03 13:57 ` Joel Granados
2025-03-03 18:53 ` Leon Romanovsky
2025-03-05 14:43 ` Joel Granados
2025-02-25 7:27 ` Zhu Yanjun
2025-02-24 9:58 ` [PATCH v2 6/6] sysctl: Fixes max-user-freq bounds nicolas.bouchinet
2025-03-03 13:52 ` [PATCH v2 0/6] Fixes multiple sysctl bound checks Joel Granados
2025-03-11 1:19 ` (subset) " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq134ftv8h4.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=Dai.Ngo@oracle.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=anna@kernel.org \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=bvanassche@acm.org \
--cc=chuck.lever@oracle.com \
--cc=clemens@ladisch.de \
--cc=codalist@coda.cs.cmu.edu \
--cc=gregkh@linuxfoundation.org \
--cc=j.granados@samsung.com \
--cc=jaharkes@cs.cmu.edu \
--cc=jgg@ziepe.ca \
--cc=jlayton@kernel.org \
--cc=joel.granados@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nicolas.bouchinet@clip-os.org \
--cc=nicolas.bouchinet@ssi.gouv.fr \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox