* [PATCH] scsi: fnic: unlock on error path in fnic_queuecommand()
@ 2024-01-10 18:41 Dan Carpenter
2024-01-12 2:14 ` Karan Tilak Kumar (kartilak)
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2024-01-10 18:41 UTC (permalink / raw)
To: Karan Tilak Kumar
Cc: Satish Kharat, Sesidhar Baddela, James E.J. Bottomley,
Martin K. Petersen, Arulprabhu Ponnusamy, linux-scsi,
linux-kernel, kernel-janitors
Call spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags) before
returning.
Fixes: c81df08cd294 ("scsi: fnic: Add support for multiqueue (MQ) in fnic driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/scsi/fnic/fnic_scsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index 4d6db4509e75..8d7fc5284293 100644
--- a/drivers/scsi/fnic/fnic_scsi.c
+++ b/drivers/scsi/fnic/fnic_scsi.c
@@ -546,6 +546,7 @@ int fnic_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc)
if (fnic->sw_copy_wq[hwq].io_req_table[blk_mq_unique_tag_to_tag(mqtag)] != NULL) {
WARN(1, "fnic<%d>: %s: hwq: %d tag 0x%x already exists\n",
fnic->fnic_num, __func__, hwq, blk_mq_unique_tag_to_tag(mqtag));
+ spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags);
return SCSI_MLQUEUE_HOST_BUSY;
}
--
2.42.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] scsi: fnic: unlock on error path in fnic_queuecommand()
2024-01-10 18:41 [PATCH] scsi: fnic: unlock on error path in fnic_queuecommand() Dan Carpenter
@ 2024-01-12 2:14 ` Karan Tilak Kumar (kartilak)
2024-01-12 2:35 ` Martin K. Petersen
2024-01-17 20:10 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Karan Tilak Kumar (kartilak) @ 2024-01-12 2:14 UTC (permalink / raw)
To: Dan Carpenter
Cc: Satish Kharat (satishkh), Sesidhar Baddela (sebaddel),
James E.J. Bottomley, Martin K. Petersen,
Arulprabhu Ponnusamy (arulponn), linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
On Wednesday, January 10, 2024 10:42 AM, Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> Call spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags) before
> returning.
>
> Fixes: c81df08cd294 ("scsi: fnic: Add support for multiqueue (MQ) in fnic driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/scsi/fnic/fnic_scsi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
> index 4d6db4509e75..8d7fc5284293 100644
> --- a/drivers/scsi/fnic/fnic_scsi.c
> +++ b/drivers/scsi/fnic/fnic_scsi.c
> @@ -546,6 +546,7 @@ int fnic_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc)
> if (fnic->sw_copy_wq[hwq].io_req_table[blk_mq_unique_tag_to_tag(mqtag)] != NULL) {
> WARN(1, "fnic<%d>: %s: hwq: %d tag 0x%x already exists\n",
> fnic->fnic_num, __func__, hwq, blk_mq_unique_tag_to_tag(mqtag));
> + spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags);
> return SCSI_MLQUEUE_HOST_BUSY;
> }
>
> --
> 2.42.0
>
>
Thanks for your change, Dan.
Looks good to me.
Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com>
Regards,
Karan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: fnic: unlock on error path in fnic_queuecommand()
2024-01-10 18:41 [PATCH] scsi: fnic: unlock on error path in fnic_queuecommand() Dan Carpenter
2024-01-12 2:14 ` Karan Tilak Kumar (kartilak)
@ 2024-01-12 2:35 ` Martin K. Petersen
2024-01-17 20:10 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2024-01-12 2:35 UTC (permalink / raw)
To: Dan Carpenter
Cc: Karan Tilak Kumar, Satish Kharat, Sesidhar Baddela,
James E.J. Bottomley, Martin K. Petersen, Arulprabhu Ponnusamy,
linux-scsi, linux-kernel, kernel-janitors
Dan,
> Call spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags) before
> returning.
Applied to 6.8/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: fnic: unlock on error path in fnic_queuecommand()
2024-01-10 18:41 [PATCH] scsi: fnic: unlock on error path in fnic_queuecommand() Dan Carpenter
2024-01-12 2:14 ` Karan Tilak Kumar (kartilak)
2024-01-12 2:35 ` Martin K. Petersen
@ 2024-01-17 20:10 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2024-01-17 20:10 UTC (permalink / raw)
To: Karan Tilak Kumar, Dan Carpenter
Cc: Martin K . Petersen, Satish Kharat, Sesidhar Baddela,
James E.J. Bottomley, Arulprabhu Ponnusamy, linux-scsi,
linux-kernel, kernel-janitors
On Wed, 10 Jan 2024 21:41:55 +0300, Dan Carpenter wrote:
> Call spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags) before
> returning.
>
>
Applied to 6.8/scsi-queue, thanks!
[1/1] scsi: fnic: unlock on error path in fnic_queuecommand()
https://git.kernel.org/mkp/scsi/c/38945c2b006b
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-17 20:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-10 18:41 [PATCH] scsi: fnic: unlock on error path in fnic_queuecommand() Dan Carpenter
2024-01-12 2:14 ` Karan Tilak Kumar (kartilak)
2024-01-12 2:35 ` Martin K. Petersen
2024-01-17 20:10 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox